Add edit command to config

Author: Monster0506

cmd/meshexec/cli_test.go

@@ -1,6 +1,8 @@
 package main
 
 import (
+	"os"
+	"path/filepath"
 	"testing"
 
 	core "github.com/monster0506/meshexec/internal"
@@ -181,3 +183,65 @@ func TestCloneFlags_ParsingOnly(t *testing.T) {
 		t.Fatalf("unexpected clone flags: target=%q dest=%q", cloneTarget, cloneDest)
 	}
 }
+
+func TestConfigEdit_InvokesEditorWithExistingFile(t *testing.T) {
+	// Arrange stub editor
+	oldRun := configRunEditor
+	defer func() { configRunEditor = oldRun }()
+	called := false
+	var gotEditor string
+	var gotArgs []string
+	configRunEditor = func(editor string, args []string) error {
+		called = true
+		gotEditor = editor
+		gotArgs = append([]string(nil), args...)
+		return nil
+	}
+
+	// Use a temporary config file
+	tmp, err := os.CreateTemp(t.TempDir(), "cfg-*.toml")
+	if err != nil {
+		t.Fatalf("temp file: %v", err)
+	}
+	_ = tmp.Close()
+
+	// Act
+	execArgs(t, "-c", tmp.Name(), "config", "edit")
+
+	// Assert
+	if !called {
+		t.Fatalf("expected editor to be invoked")
+	}
+	if gotEditor == "" {
+		t.Fatalf("expected an editor command to be chosen")
+	}
+	if len(gotArgs) == 0 || gotArgs[len(gotArgs)-1] != tmp.Name() {
+		t.Fatalf("expected editor args to end with config path; args=%v path=%q", gotArgs, tmp.Name())
+	}
+}
+
+func TestConfigEdit_CreatesDefaultWhenMissing(t *testing.T) {
+	// Arrange: stub editor to no-op
+	oldRun := configRunEditor
+	defer func() { configRunEditor = oldRun }()
+	configRunEditor = func(editor string, args []string) error { return nil }
+
+	// Use path inside temp dir that does not exist yet
+	dir := t.TempDir()
+	cfgPath := filepath.Join(dir, "config.toml")
+	if _, err := os.Stat(cfgPath); !os.IsNotExist(err) {
+		t.Fatalf("expected non-existent path for test, got err=%v", err)
+	}
+
+	// Act
+	execArgs(t, "-c", cfgPath, "config", "edit")
+
+	// Assert: file should now exist and be non-empty
+	st, err := os.Stat(cfgPath)
+	if err != nil {
+		t.Fatalf("expected config file to be created: %v", err)
+	}
+	if st.Size() == 0 {
+		t.Fatalf("expected created config to be non-empty")
+	}
+}

cmd/meshexec/config.go

@@ -9,7 +9,6 @@ import (
 	"strings"
 
 	"github.com/monster0506/meshexec/internal"
-	"github.com/monster0506/meshexec/internal/config"
 	"github.com/spf13/cobra"
 )
 
@@ -19,6 +18,18 @@ var configCmd = &cobra.Command{
 	Long:  `Manage MeshExec CLI configuration files and settings.`,
 }
 
+// indirections for testability
+var (
+	// configNewManagerWithLevel is declared in network.go for package-wide reuse
+	configRunEditor = func(editor string, argsWithFile []string) error {
+		c := exec.Command(editor, argsWithFile...)
+		c.Stdin = os.Stdin
+		c.Stdout = os.Stdout
+		c.Stderr = os.Stderr
+		return c.Run()
+	}
+)
+
 var configShowCmd = &cobra.Command{
 	Use:   "show",
 	Short: "Show current configuration",
@@ -28,7 +39,7 @@ var configShowCmd = &cobra.Command{
 		if verbose {
 			logLevel = "debug"
 		}
-		manager := config.NewManagerWithLevel(logLevel)
+		manager := configNewManagerWithLevel(logLevel)
 
 		// Get config path from global flags
 		configPath, _ := cmd.Root().PersistentFlags().GetString("config")
@@ -64,7 +75,7 @@ var configInitCmd = &cobra.Command{
 		if verbose {
 			logLevel = "debug"
 		}
-		manager := config.NewManagerWithLevel(logLevel)
+		manager := configNewManagerWithLevel(logLevel)
 
 		// Get config path from global flags
 		configPath, _ := cmd.Root().PersistentFlags().GetString("config")
@@ -92,7 +103,7 @@ var configEditCmd = &cobra.Command{
 		if verbose {
 			logLevel = "debug"
 		}
-		manager := config.NewManagerWithLevel(logLevel)
+		manager := configNewManagerWithLevel(logLevel)
 
 		// Respect global --config path
 		if configPath, _ := cmd.Root().PersistentFlags().GetString("config"); configPath != "" {
@@ -157,11 +168,7 @@ var configEditCmd = &cobra.Command{
 			logger.Info("config edit: opening editor", map[string]interface{}{"editor": editor, "args": strings.Join(editorArgs, " "), "path": cfgPath})
 		}
 
-		c := exec.Command(editor, argsWithFile...)
-		c.Stdin = os.Stdin
-		c.Stdout = os.Stdout
-		c.Stderr = os.Stderr
-		if err := c.Run(); err != nil {
+		if err := configRunEditor(editor, argsWithFile); err != nil {
 			me := internal.NewConfigError("editor_failed", "failed to open editor", map[string]interface{}{"editor": editor, "error": err.Error()})
 			fmt.Fprintln(os.Stderr, internal.FormatUserError(me))
 			os.Exit(1)
@@ -188,7 +195,7 @@ var configValidateCmd = &cobra.Command{
 		if verbose {
 			logLevel = "debug"
 		}
-		manager := config.NewManagerWithLevel(logLevel)
+		manager := configNewManagerWithLevel(logLevel)
 		configPath, _ := cmd.Root().PersistentFlags().GetString("config")
 		if configPath != "" {
 			manager.SetConfigPath(configPath)