Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: rename to vscode-light.nvim #5

Open
wongjiahau opened this issue Jun 13, 2021 · 10 comments
Open

Suggestion: rename to vscode-light.nvim #5

wongjiahau opened this issue Jun 13, 2021 · 10 comments

Comments

@wongjiahau
Copy link
Contributor

Problem

Currently this repository is almost unsearchable from Google and DuckDuckGo. Even in Github, it is not apparent.

image

image

image

Suggestion

Rename to something like vscode-light.nvim or vim-code-light (contrary to vim code dark).

@Mofiqul
Copy link
Owner

Mofiqul commented Jun 13, 2021

I also feel like a renamed is necessary because vscode.nvim does not sound like a color scheme. As it has both light and dark variant, I am not sure about vim-code-light or vscode-light.nvim. Can we do something else?

@mkblast
Copy link

mkblast commented Jul 17, 2021

How about Dark+.nvim or Vsdark+.nvim

@wongjiahau
Copy link
Contributor Author

How about vscode-light-dark.nvim?

@vicecaycedo
Copy link

It shouldn't include light or dark in the name since most themes include light and dark variations.

It'd be better to include vim, nvim, theme, and/or colorscheme in the name instead.

Including vim or nvim in the name provides an indication that this is a theme for Vim/Neovim (not VSCode or any other editors).

I'd go with something like vim-vscode-theme. Not sure how SEO-friendly that is, however.

@wongjiahau
Copy link
Contributor Author

@vicecaycedo I think vim-vscode-theme sounds great!

@vicecaycedo
Copy link

After some more thought, given that this is a Lua port and as such is incompatible with Vim, it'd probably be best to go with something like nvim-vscode-theme or vscode-theme.nvim.

@Mofiqul
Copy link
Owner

Mofiqul commented Jul 17, 2021

@vicecaycedo @wongjiahau nvim-vscode-theme and vscode-theme.nvim both are tasteful to me. As everyone is putting .nvim for their plugin and color scheme names for Neo vim, I want to go for the same direction.

@markstos
Copy link

It looks there there's agreement that either nvim-vscode-theme or vscode-theme.nvim are both good choices.

@doanngochieuo
Copy link

doanngochieuo commented Oct 27, 2024

need to rename this plugin as i got conflict issue with vscode's vscode-neovim, either should change name, vscode-neovim/vscode-neovim#1996

edit: but just rename the downloaded folder would work :)

@doanngochieuo
Copy link

seem like vscode-neovim uses module named vscode, and this plugin also use that under lua/vscode/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants