From 524516c95fa23e522d1499df190ece53af7aec6a Mon Sep 17 00:00:00 2001 From: Dionisio E Alonso Date: Sat, 16 Jul 2022 19:02:21 -0300 Subject: [PATCH 1/2] fix: Change vim.g.transparency check to vim.g.transparent Also test for boolean values of backwards compatible configs on top of the already tested integer values. --- lua/vscode/init.lua | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lua/vscode/init.lua b/lua/vscode/init.lua index 03cc2b7..c0a8a94 100644 --- a/lua/vscode/init.lua +++ b/lua/vscode/init.lua @@ -15,8 +15,10 @@ vscode.setup = function(user_opts) -- backwards compatibility: let users still set settings with global vars local global_settings_opts = vim.tbl_extend('force', defaults, { - transparent = vim.g.vscode_transparency == 1, - italic_comments = vim.g.vscode_italic_comment == 1, + transparent = (vim.g.vscode_transparent == true + or vim.g.vscode_transparent == 1), + italic_comments = (vim.g.vscode_italic_comment == true + or vim.g.vscode_italic_comment == 1), disable_nvimtree_bg = vim.g.vscode_disable_nvim_tree_bg == true, }) From 6cbb949822d2f5d5d83fe0d686ad56a101c9dc67 Mon Sep 17 00:00:00 2001 From: Dionisio E Alonso Date: Sun, 17 Jul 2022 13:00:04 -0300 Subject: [PATCH 2/2] fix: Add the same validations to vim.g.vscode_disable_nvim_tree_bg Just for completeness add the same validation for all the backwards compatible options in vim-script. --- lua/vscode/init.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lua/vscode/init.lua b/lua/vscode/init.lua index c0a8a94..e40846b 100644 --- a/lua/vscode/init.lua +++ b/lua/vscode/init.lua @@ -19,7 +19,8 @@ vscode.setup = function(user_opts) or vim.g.vscode_transparent == 1), italic_comments = (vim.g.vscode_italic_comment == true or vim.g.vscode_italic_comment == 1), - disable_nvimtree_bg = vim.g.vscode_disable_nvim_tree_bg == true, + disable_nvimtree_bg = (vim.g.vscode_disable_nvim_tree_bg == true + or vim.g.vscode_disable_nvim_tree_bg == 1), }) -- but override global vars settings with setup() settings