Skip to content

Splitter usage in Designer #16

@xandaau

Description

@xandaau

The Designer class in its work uses own methods for generating subsamples in an empirical approach.
Let's think about switching to using the Splitter class for the tasks of subsamples generation inside the Designer.

Currently, I see the following advantages of this choice:

  1. The code will be more consistent and clear because the Splitter is designed specifically to generate subsamples(actually set of subgroups).
  2. In the future, there will be no need to duplicate the same features for split and design methods.
  3. Simultaneous refactoring of old and duplicated pieces of code in tools.py and others modules
  4. We could pass custom configuration for the Splitter instance inside the methods, which would help keep the empirical design more flexible and correct for custom splitting.

The cons should be considered as well, for example, there may be some problems with generation of a large number of group pairs with current structure of the Splitter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussDiscussion and reflection neededenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions