Skip to content

Conversation

@georgeee
Copy link
Member

@georgeee georgeee commented Sep 19, 2025

This PR reverts these commit and PR:

The parsing feature won't be needed anymore in Mesa HF, hence no need to keep the code.

And also part of PR #17115.

Motivation for the change:

  1. We're going to change the block format, so the test relying on an old block from devnet will fail
  2. We'd need to artificially recreate the test file
  3. The fallback that is reverted here won't be needed anymore, because from Mesa HF onwards there won't be any block using decimal format for the authorization_kind field

Explain how you tested your changes:

  • Relying on an existing test suite

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested review from a team as code owners September 19, 2025 18:02
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member Author

!ci-bypass-changelog

@georgeee georgeee changed the title Remove legacy authorization_kind JSOn parsing Remove legacy authorization_kind JSON parsing Sep 19, 2025
@glyh
Copy link
Member

glyh commented Sep 20, 2025

Parts of this PR #17105 need to be reverted as well

@georgeee
Copy link
Member Author

Answering to Christian's question posted on Slack:

How is the authorization kind stored and parsed in the archive? Is that something we need to consider if we remove this parsing code?

This is a good question. Archive is probably the only component which may get a piece of data from the old network, we need to check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants