Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect lookup PR#1263 after revert #14674

Closed
volhovm opened this issue Dec 7, 2023 · 1 comment
Closed

Resurrect lookup PR#1263 after revert #14674

volhovm opened this issue Dec 7, 2023 · 1 comment
Assignees

Comments

@volhovm
Copy link
Member

volhovm commented Dec 7, 2023

The PR o1-labs/proof-systems#1263 was reverted due to the problem https://app.zenhub.com/workspaces/core-crypto-621fcb82b7d49700156fd060/issues/gh/minaprotocol/mina/14657 that was created by the merge commit.

It is likely that only one small part of the PR1263 was an issue, and as PR1263 was solving several issues (fixed another bug, added more assertions/tests) so it should be merged back after figuring out what the bug was, and removing that bit.

@volhovm volhovm self-assigned this Dec 7, 2023
volhovm added a commit to o1-labs/proof-systems that referenced this issue Dec 8, 2023
volhovm added a commit to o1-labs/proof-systems that referenced this issue Dec 8, 2023
Important! Note that this commit /still/ has the bug mina#14657.
It will be fixed in the next commit explicitly, so that the bug
can be hunted down.
@volhovm
Copy link
Member Author

volhovm commented Dec 11, 2023

volhovm added a commit to o1-labs/proof-systems that referenced this issue Jan 3, 2024
Important! Note that this commit /still/ has the bug mina#14657.
It will be fixed in the next commit explicitly, so that the bug
can be hunted down.
volhovm added a commit to o1-labs/proof-systems that referenced this issue Jan 3, 2024
Important! Note that this commit /still/ has the bug mina#14657.
It will be fixed in the next commit explicitly, so that the bug
can be hunted down.
@volhovm volhovm closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant