Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After today's update (v1.1.1) it stopped working, error in js console #53

Open
admg opened this issue Jul 9, 2019 · 6 comments
Open

Comments

@admg
Copy link

admg commented Jul 9, 2019

Not showing pull requests, there's an error in js console in browser. TFS is on premise.

image

bundle.js:53 Uncaught (in promise) TFS.WebApi.Exception: 404: Not Found at Object.<anonymous> (http://***:8080/tfs/_apis/public/gallery/publisher/mimeo-vs-marketplace/extension/mimeo-active-pull-requests/1.1.1/assetbyname/dist/bundle.js:53:51961) at http://***:8080/tfs/_apis/public/gallery/publisher/mimeo-vs-marketplace/extension/mimeo-active-pull-requests/1.1.1/assetbyname/dist/bundle.js:53:50486 at Object.next (http://***:8080/tfs/_apis/public/gallery/publisher/mimeo-vs-marketplace/extension/mimeo-active-pull-requests/1.1.1/assetbyname/dist/bundle.js:53:50591) at a (http://***:8080/tfs/_apis/public/gallery/publisher/mimeo-vs-marketplace/extension/mimeo-active-pull-requests/1.1.1/assetbyname/dist/bundle.js:53:49337)

@johngraumann
Copy link

We are seeing the same exception. We are running Azure DevOps Server 2019.

@joelbourbon
Copy link
Contributor

This is the part in code that probably breaks on premise:
image

It also would not work for teams still using the old URLs (organization.visualstudio.com).

Not sure with what it can be replaced....

@joelbourbon
Copy link
Contributor

Here is a great article on how URLs should be managed in extensions:
https://docs.microsoft.com/en-us/azure/devops/extend/develop/work-with-urls?view=azure-devops&tabs=nodejsgeneric

@joelbourbon
Copy link
Contributor

Oh sorry guys I was wrong. What I found is probably causing other issues.

The bug you found seems to be related to the BuildRestClient. The way it is used is fairly straightforward and I don't see how this could be fixed for On-Premise. Seems like an issue in the underlying library used here --> azure-devops-extension-api

@persalmi
Copy link

Is anyone working on a resolution for this problem? The hard reference to dev.azure.com seems easy to fix but is it the whole truth for getting the extension to work on-premise again?

@wadechandler
Copy link

I'm seeing a definite issue with the cross domain problem mentioned above by @joelbourbon and we have a different URL we access from yet still the SaaS version (as we've been on ADO a long time). It seems the URL the user is already using in the browser should be used versus the hard coded version as mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants