Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Game Visuals #2

Open
CMahaff opened this issue Aug 19, 2013 · 2 comments
Open

Improve Game Visuals #2

CMahaff opened this issue Aug 19, 2013 · 2 comments

Comments

@CMahaff
Copy link
Contributor

CMahaff commented Aug 19, 2013

Note: With current visuals, some button text falls outside of the button, may need to shrink font.

@mfansler
Copy link
Member

I notice that an incorrect answer can only be clicked once. While the user probably shouldn't be silly enough to try to click it again, it might be worth including some visual cue to show that 1) that answer was wrong and 2) the button is now disabled. Something like turning the button background red and making it unresponsive to :hover actions is one possibility.

@CMahaff
Copy link
Contributor Author

CMahaff commented Sep 4, 2013

I agree that this needed to be done. For some reason, I couldn't get this to work with CSS. I added a .incorrect class to gamescreen, then used .addClass to change the button, and while I could confirm it added the class, the buttons stayed gray. Does .button maybe hold higher priority? I did try removing the button class then re-adding with .addClass('incorrect button') but that still didn't work. For now, it is using .css('background-color', 'red')

Also, to get this to work I had to add a new variable to keep track of the last button the user pressed, this.currentAnswer - as well as added the answer id as an html id (there might be a way to get the id from data-logic though). But the answer the user chose was not passed down to the function that sets incorrect or correct, only the server reponse which is essentially true/false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants