Refactor ad loading logic and update ic_open_in_new icon

- Removed consent check before loading ads in `HomeFragment`, `AboutFragment`, and `MainActivity`.
- Renamed `ConsentUtils.canShowAds` to `canShowPersonalizedAds`.
- Updated `ic_open_in_new.xml` with a new path data.
- Updated tests in `ConsentUtilsTest` to reflect the method rename.
- `AndroidStudioFragment` now uses `canShowPersonalizedAds` to determine if ads should be shown.

Author: MihaiCristianCondrea

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/about/AboutFragment.java

@@ -40,12 +40,8 @@ public android.view.View onCreateView(@NonNull android.view.LayoutInflater infla
 
         new FastScrollerBuilder(binding.scrollView).useMd2Style().build();
 
-        if (ConsentUtils.canShowAds(requireContext())) {
-            binding.adView.setVisibility(android.view.View.VISIBLE);
-            AdUtils.loadBanner(binding.adView);
-        } else {
-            binding.adView.setVisibility(android.view.View.GONE);
-        }
+        binding.adView.setVisibility(android.view.View.VISIBLE);
+        AdUtils.loadBanner(binding.adView);
 
         String version = aboutViewModel.getVersionString();
         binding.textViewAppVersion.setText(version);

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/AndroidStudioFragment.java

@@ -71,7 +71,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
     @Override
     public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
-        showAds = ConsentUtils.canShowAds(requireContext());
+        showAds = ConsentUtils.canShowPersonalizedAds(requireContext());
         if (showAds) {
             ensureMobileAdsInitialized();
         }

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/home/HomeFragment.java

@@ -83,15 +83,10 @@ public void onDestroyView() {
     }
 
     private void initializeAds() {
-        if (ConsentUtils.canShowAds(requireContext())) {
-            binding.smallBannerAd.setVisibility(View.VISIBLE);
-            binding.largeBannerAd.setVisibility(View.VISIBLE);
-            AdUtils.loadBanner(binding.smallBannerAd);
-            AdUtils.loadBanner(binding.largeBannerAd);
-        } else {
-            binding.smallBannerAd.setVisibility(View.GONE);
-            binding.largeBannerAd.setVisibility(View.GONE);
-        }
+        binding.smallBannerAd.setVisibility(View.VISIBLE);
+        binding.largeBannerAd.setVisibility(View.VISIBLE);
+        AdUtils.loadBanner(binding.smallBannerAd);
+        AdUtils.loadBanner(binding.largeBannerAd);
     }
 
     private void shareTip(String tip) {

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/main/MainActivity.java

@@ -72,14 +72,9 @@ public class MainActivity extends AppCompatActivity {
         public void onResume(@NonNull LifecycleOwner owner) {
             ConsentUtils.applyStoredConsent(MainActivity.this);
             if (mBinding != null && mBinding.adView != null) {
-                if (ConsentUtils.canShowAds(MainActivity.this)) {
-                    mBinding.adPlaceholder.setVisibility(View.GONE);
-                    mBinding.adView.setVisibility(View.VISIBLE);
-                    AdUtils.loadBanner(mBinding.adView);
-                } else {
-                    mBinding.adView.setVisibility(View.GONE);
-                    mBinding.adPlaceholder.setVisibility(View.VISIBLE);
-                }
+                mBinding.adPlaceholder.setVisibility(View.GONE);
+                mBinding.adView.setVisibility(View.VISIBLE);
+                AdUtils.loadBanner(mBinding.adView);
             }
         }
     };
@@ -216,14 +211,9 @@ private void observeViewModel() {
 
                 navBarView.setLabelVisibilityMode(uiState.bottomNavVisibility());
                 if (binding.adView != null) {
-                    if (ConsentUtils.canShowAds(this)) {
-                        binding.adPlaceholder.setVisibility(View.GONE);
-                        binding.adView.setVisibility(View.VISIBLE);
-                        AdUtils.loadBanner(binding.adView);
-                    } else {
-                        binding.adView.setVisibility(View.GONE);
-                        binding.adPlaceholder.setVisibility(View.VISIBLE);
-                    }
+                    binding.adPlaceholder.setVisibility(View.GONE);
+                    binding.adView.setVisibility(View.VISIBLE);
+                    AdUtils.loadBanner(binding.adView);
                 }
             }
 

app/src/main/java/com/d4rk/androidtutorials/java/utils/ConsentUtils.java

@@ -40,7 +40,7 @@ public static void updateFirebaseConsent(Context context,
         FirebaseAnalytics.getInstance(context).setConsent(consentMap);
     }
 
-    public static boolean canShowAds(Context context) {
+    public static boolean canShowPersonalizedAds(Context context) {
         SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
         return prefs.getBoolean(context.getString(R.string.key_consent_ad_storage), true);
     }

app/src/main/res/drawable-anydpi/ic_open_in_new.xml

@@ -1,9 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
     android:width="24dp"
     android:height="24dp"
     android:viewportWidth="24"
     android:viewportHeight="24">
     <path
         android:fillColor="?attr/colorOnSurfaceVariant"
-        android:pathData="M14,3v2h3.59l-4.83,4.83 1.41,1.41L19,6.41V10h2V3h-7zM5,5h6V3H5c-1.1,0 -2,0.9 -2,2v14c0,1.1 0.9,2 2,2h14c1.1,0 2,-0.9 2,-2v-6h-2v6H5V5z" />
-</vector>
+        android:pathData="M19 4H5c-1.11 0-2 0.9-2 2v12c0 1.1 0.89 2 2 2h4v-2H5V8h14v10h-4v2h4c1.1 0 2-0.9 2-2V6c0-1.1-0.89-2-2-2zm-7 6l-4 4h3v6h2v-6h3l-4-4z" />
+</vector>

app/src/test/java/com/d4rk/androidtutorials/java/utils/ConsentUtilsTest.java

@@ -113,10 +113,10 @@ public void canShowAds_readsStoredPreference() {
             prefsStatic.when(() -> PreferenceManager.getDefaultSharedPreferences(context)).thenReturn(prefs);
 
             when(prefs.getBoolean("consent_ad_storage", true)).thenReturn(false);
-            assertFalse(ConsentUtils.canShowAds(context));
+            assertFalse(ConsentUtils.canShowPersonalizedAds(context));
 
             when(prefs.getBoolean("consent_ad_storage", true)).thenReturn(true);
-            assertTrue(ConsentUtils.canShowAds(context));
+            assertTrue(ConsentUtils.canShowPersonalizedAds(context));
         }
     }
 
@@ -132,7 +132,7 @@ public void canShowAds_returnsDefaultWhenPreferenceMissing() {
             when(prefs.getBoolean("consent_ad_storage", true))
                     .thenAnswer(invocation -> invocation.getArgument(1));
 
-            assertTrue(ConsentUtils.canShowAds(context));
+            assertTrue(ConsentUtils.canShowPersonalizedAds(context));
             verify(prefs).getBoolean("consent_ad_storage", true);
         }
     }