Barcelona | 25-ITP-OCT | Basma Malainine | Sprint 1 | Wireframe #57
Conversation
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> |
There was a problem hiding this comment.
I would suggest to use the <main> element and wrap the whole section till before the <footer>, meaning include inside the <main> all <section> elements
| <main> | ||
| <article> | ||
| <img | ||
| src="https://assets.pinterest.com/ext/embed.html?id=492649946889933" height="636" width="345" frameborder="0" scrolling="no" alt=""/> |
There was a problem hiding this comment.
it's a good practice to always include an alt tag including a description usually of the image like alt="Portrait of a lady..." in the <img> elements, this is for accessibility purposes and it is strongly recommended
| <div class="content"> | ||
| <h2>Isaac de Moucheron (Amsterdam 1667-1744 Amsterdam)</h2> | ||
| <p>Isaac de Moucheron (Amsterdam, 1667–1744) was a Dutch painter and draughtsman best known for his elegant **Italianate landscape paintings**. Influenced by French classicism and artists like Gaspard Dughet, his works often depict idealized ruins, harbors, and pastoral scenes bathed in warm light. De Moucheron’s landscapes emphasize balance, atmosphere, and architectural detail, reflecting the Dutch Golden Age fascination with travel, nature, and classical antiquity.</p> | ||
| <button>Read more</button> |
There was a problem hiding this comment.
Minor comment but sometimes you use a link element <a> and sometimes a <button> for the Read More, usually if you want to navigate to a new page it's better to use a link
| </article> | ||
| </main> | ||
| <section class="article featured"> | ||
| <div class="https://assets.pinterest.com/ext/embed.html?id=3237030974549846" height="517" width="345" frameborder="0" scrolling="no"></div> |
There was a problem hiding this comment.
Maybe you wanted to use an element here instead of a
<div>? like above, cause this is not going to smake the image to appear
| </div> | ||
| </section> | ||
| <section class="article-grid"> | ||
| <div class="article"> |
There was a problem hiding this comment.
This is for future reference and maybe a good practice for the class names https://getbem.com/introduction/
|
One more generic thing, file extension looks missing. Using Overall nice work on this PR, the layout is clear, the content reads well, and the structure is going in the correct direction. |
2 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.