Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most Toolbar Buttons Do Not Function in Latest Git Builds #186

Closed
bongochong opened this issue Dec 28, 2022 · 4 comments · Fixed by #189
Closed

Most Toolbar Buttons Do Not Function in Latest Git Builds #186

bongochong opened this issue Dec 28, 2022 · 4 comments · Fixed by #189
Assignees
@MightyCreak
Labels
bug

Comments

@bongochong
Copy link
Contributor

bongochong commented Dec 28, 2022 •
edited
Loading

When building from git, since this commit on Nov 21, 2022, most of the toolbar buttons in the main window do not perform their associated actions (relevant buttons). Every button except New 2-Way File Merge and New 3-Way File Merge fails to have an effect when clicked. Menu entries still do work for these actions, so it's a bit puzzling. Tested on Fedora 36 and 37 under the Cinnamon desktop environment. Said toolbar buttons do work in the latest stable release by the way.
@MightyCreak
Copy link
Owner

It comes from one of my refactorings. I'm looking for a proper fix right now. Sorry for the delay.

MightyCreak added a commit that referenced this issue Jan 22, 2023
@MightyCreak
fix: clicking buttons in the toolbar was crashing
81b9066 
Fixes #186
@MightyCreak MightyCreak mentioned this issue Jan 22, 2023
Merged
@MightyCreak MightyCreak mentioned this issue Jan 22, 2023
Closed
@bongochong
Copy link
Contributor Author

Awesome! Now I can resume doing git builds for COPR again.

@MightyCreak
Copy link
Owner

There's still #188 which is a bit concerning. Didn't have time today to look at it. Might be very simple to fix... or not 😅

@MightyCreak MightyCreak self-assigned this Jan 23, 2023
@bongochong
Copy link
Contributor Author

Ah, I'll hang tight then. Thank you for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MightyCreak MightyCreak

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clicking buttons in the toolbar was crashing MightyCreak/diffuse
2 participants
@MightyCreak @bongochong