File tree Expand file tree Collapse file tree 2 files changed +7
-5
lines changed Expand file tree Collapse file tree 2 files changed +7
-5
lines changed Original file line number Diff line number Diff line change 19
19
- [x] Shows custom thumbnail when sharing url on WhatsApp/Social Media using Open Graph Metadata Protocol
20
20
- [x] Automatically changes theme based on device ` Dark Mode ` setting (stackoverflow does not seem to have this feature).
21
21
- [x] SVG icons changes colors automatically based on selected theme.
22
- - [x] Fully [ Responsive Design ] (https://en.wikipedia.org/wiki/Responsive_web_design ) - Adapts to different viewports
22
+ - [x] Fully [ Responsive Design ] ( https://en.wikipedia.org/wiki/Responsive_web_design ) - Adapts to different viewports
23
23
- [x] Better [ accessibility ] ( https://en.wikipedia.org/wiki/Web_accessibility ) for keyboard users
24
24
- [x] Implemented XML like component abstaction for data on ` ./world/workshop.tsx `
25
25
- [x] Implemented JSON file reading for data on ` ./world/skills.tsx `
Original file line number Diff line number Diff line change @@ -72,8 +72,10 @@ export default function Skills() {
72
72
const skillElements = [ ] ;
73
73
if ( skills ) {
74
74
for ( const [ title , skillList ] of Object . entries ( skills ) ) {
75
- skillElements . push (
76
- ...skillList . map ( ( skill , index ) => (
75
+ // Using loops over .map() as Heap/GC allocation in JS is expensive.
76
+ for ( let index = 0 ; index < skillList . length ; index ++ ) {
77
+ const skill = skillList [ index ] ;
78
+ skillElements . push (
77
79
< div
78
80
key = { `${ title } -${ index } ` }
79
81
className = "place-content-center p-5 bg-white border border-gray-200 rounded-lg shadow hover:bg-gray-100 dark:bg-[#161D1F] dark:border-gray-700 dark:hover:bg-gray-700"
@@ -89,8 +91,8 @@ export default function Skills() {
89
91
height = { 100 }
90
92
/>
91
93
</ div >
92
- ) ) ,
93
- ) ;
94
+ ) ;
95
+ }
94
96
}
95
97
}
96
98
return skillElements ;
You can’t perform that action at this time.
0 commit comments