Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The doc page "Chaining functions together" needs some cleanup #55

Open
sramaswami11 opened this issue Oct 24, 2023 · 1 comment
Open

Comments

@sramaswami11
Copy link

Please refer to the following url:
https://learn.microsoft.com/en-us/semantic-kernel/ai-orchestration/plugins/chaining-functions?tabs=Csharp
The code block right underneath the section "Using the RunAsync method to chain our functions" is confusing and redundant.
Redundant since the whole code block is repeated below under the section "Creating a semantic function that uses the new context variables" (and more complete there creating an saving off new context with the original _context).
Confusing since it has the line of code that tries to get the function "CreateResponse" which has not yet been created. Someone following this code will run into an error. So this whole block of code section needs to be removed. Or this code block can clarify that the CreateResponse function will be created later on this page.

@crickman
Copy link
Contributor

I suspect this will be responded to more directly by posting in the semantic-kernel repo directly: https://github.com/microsoft/semantic-kernel)

I know this is under heavy review as part of the march towards release (currently beta3: https://github.com/microsoft/semantic-kernel/releases/tag/dotnet-1.0.0-beta3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants