Skip to content

Commit 650d201

Browse files
committed
fix: Address code review feedback
- Add command field to training-health-cronjob and eval-health-cronjob - Fix workflow exclusion logic to check both workflow name and ID
1 parent 6a73320 commit 650d201

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

devops/charts/helmfile.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ releases:
223223
tag: latest-dashboard
224224
- datadog:
225225
service: training-health-collector
226+
- command:
227+
- python
228+
- -m
229+
- devops.datadog.cli
226230
- args:
227231
- collect
228232
- training
@@ -236,6 +240,10 @@ releases:
236240
tag: latest-dashboard
237241
- datadog:
238242
service: eval-health-collector
243+
- command:
244+
- python
245+
- -m
246+
- devops.datadog.cli
239247
- args:
240248
- collect
241249
- eval

devops/datadog/collectors/ci_collector.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,10 @@ def _count_other_workflows_failing(self) -> int:
320320
failing_count = 0
321321
for workflow in all_workflows:
322322
workflow_name = workflow.get("name") or workflow.get("path", "").split("/")[-1]
323-
workflow_id = workflow.get("id")
323+
workflow_id = str(workflow.get("id", ""))
324324

325-
# Skip if this is a test/benchmark workflow
326-
if workflow_name in exclude_workflows:
325+
# Skip if this workflow matches by name OR id
326+
if workflow_name in exclude_workflows or workflow_id in exclude_workflows:
327327
continue
328328

329329
# Get latest run for this workflow

0 commit comments

Comments
 (0)