Skip to content

Commit ec2a0e6

Browse files
release(runway): cherry-pick chore: menu item text cp-13.10.0 (#37981)
- chore: menu item text cp-13.10.0 (#37916) ## **Description** Removes the "MetaMask Extension" subtitle in the Open full screen menu item [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37916?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix: open full screen text ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-684 ## **Manual testing steps** Open main menu, observe Open full screen item ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="234" height="53" alt="image" src="https://github.com/user-attachments/assets/84123d29-6225-4b15-9fc4-1652ecae5971" /> ### **After** <img width="233" height="46" alt="image" src="https://github.com/user-attachments/assets/1e1d6278-3cc2-409a-9df1-b8e1b6b0ad9c" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes the “MetaMask Extension” subtitle from the Global Menu’s “Open full screen” item and deletes the unused `metamaskExtension` i18n key. > > - **UI**: > - `ui/components/multichain/global-menu/global-menu.tsx`: Remove subtitle under `openFullScreen` menu item; item now shows only `t('openFullScreen')`. > - **i18n**: > - Delete `metamaskExtension` key from `app/_locales/en/messages.json` and `app/_locales/en_GB/messages.json`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6f65b2d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [20f49e6](20f49e6) Co-authored-by: Francis Nepomuceno <[email protected]>
1 parent 63039bb commit ec2a0e6

File tree

3 files changed

+0
-13
lines changed

3 files changed

+0
-13
lines changed

app/_locales/en/messages.json

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/en_GB/messages.json

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ui/components/multichain/global-menu/global-menu.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import {
3737
Popover,
3838
PopoverPosition,
3939
Tag,
40-
Text,
4140
} from '../../component-library';
4241

4342
import { MenuItem } from '../../ui/menu';
@@ -410,12 +409,6 @@ export const GlobalMenu = ({
410409
data-testid="global-menu-expand-view"
411410
>
412411
{t('openFullScreen')}
413-
<Text
414-
variant={TextVariant.bodySmMedium}
415-
color={TextColor.textAlternative}
416-
>
417-
{t('metamaskExtension')}
418-
</Text>
419412
</MenuItem>
420413
)}
421414
{account &&

0 commit comments

Comments
 (0)