Add land and sea mask recipes for timeseries #1874
Conversation
|
|
|
When reviewing be aware of #1876. |
|
Need to check how NaNs are handled in collapse as might be causing a problem or two in runs coming up with no values. |
daflack
force-pushed
the
1873_land_sea_mask_application
branch
3 times, most recently
from
5d9a7bb to
75ed7e0
Compare
daflack
force-pushed
the
1873_land_sea_mask_application
branch
from
75ed7e0 to
b04e6eb
Compare
and adds extra test
|
Fix in commit e6dadd0 linked to #984 and may help close that issue (not sure if it fully closes it). |
Evidence of the land-sea mask splits working as expected for four difference models.
|
daflack
requested review from
BernardClaxton,
Sylviabohnenstengel,
cehalliwell,
jfrost-mo,
mo-jthornton,
mo-sanamahmood and
mo-sro
|
I see that in the example time series plots, the x-axis is labelled as "hours since..." but the time seems to be "MM-DD HH". Is this minor error unique to this recipe, or is it more common to CSET ? |
It's more common to CSET than this recipe. Likely to be due to the underlying data used in the plot and where the relevant information is got and how that goes through CSET. |
In this case, it's probably because the input data is an ancillary file rather than a model output file. The metadata (i.e. FieldsFile/PP headers) describing time is different for ancillaries. I'm not sure exactly how Iris and/or CSET has converted it to those labels though. |
|
IIRC this affects most plots CSET produces. The axis label comes from the units of the data cube, which is 'hours since 1970', however when we actually pass those labels to matplotlib they are converted to datetime objects, which get displayed as dates. This is probably what we want most of the time, as "01-22 17" is usually more meaningful than "491417", though it would be nice to correct the units. The date format is just matplotlib's default for dates, though we should probably make it use a more standard ISO 8601 format at some point. |
|
Just linking in #1112 as probably linked to discussion above (hence not opening a new issue). |
Fixes #1873
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.