Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impact severity to each violation #87

Open
4 tasks
MelSumner opened this issue Nov 2, 2020 · 1 comment
Open
4 tasks

Add impact severity to each violation #87

MelSumner opened this issue Nov 2, 2020 · 1 comment
Labels
enhancement New feature or request hacktoberfest help wanted Open to contributions for this issue pr-welcome pull requests are welcome for this issue

Comments

@MelSumner
Copy link
Owner

MelSumner commented Nov 2, 2020

To help prioritize rules to be written or issues to be fixed, each existing detail needs a severity level added.

Severity should be based on impact to the user:

  • blocker (no workaround, would cause loss of service or loss of critical functionality)
  • critical (functionality is still available but is severely limited; no acceptable workaround is available)
  • major (reasonable workaround available; no user-generated data would be lost)
  • minor (degradation of non-critical functionality; workaround may be available)

To complete:

  • add severity to the attributes list in lib/content-generator/index.js
  • add severity to the front-matter list in blueprints/violations/files/details__name__.md
  • add severity to each existing violations file with the correct severity indicated
  • add a severity indicator in the templates/violations/violation file, and any supporting CSS necessary.
@MelSumner MelSumner added the enhancement New feature or request label Nov 2, 2020
@MelSumner MelSumner added help wanted Open to contributions for this issue pr-welcome pull requests are welcome for this issue labels Sep 21, 2021
@MelSumner MelSumner changed the title Add severity to each detail Add impact severity to each violation Sep 21, 2021
@MelSumner
Copy link
Owner Author

Another potential approach would be to take the same "weight" that Lighthouse gives each rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Open to contributions for this issue pr-welcome pull requests are welcome for this issue
Projects
None yet
Development

No branches or pull requests

1 participant