Skip to content

Commit bc62b01

Browse files
authored
Merge pull request #13 from reeyur/bugfix/update-request-response
Request和Response声明数据时,去掉显式new HashMap,否在客户在用的时候,被限制为HashMap类型数据,改为灵活一…
2 parents 6d19962 + 3d729c2 commit bc62b01

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

src/main/java/com/meituan/lyrebird/client/api/Request.java

+9-9
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@
77

88
@JsonIgnoreProperties(ignoreUnknown = true)
99
public class Request {
10-
private Map<String, String> headers = new HashMap<>();
10+
private Map headers;
1111
private String method;
12-
private Map<String, String> query = new HashMap<>();
12+
private Map query;
1313
private String url;
1414
private String host;
1515
private String path;
16-
private Map<String, ?> data = new HashMap<>();
16+
private Map data;
1717

18-
public Map<String, String> getHeaders() {
18+
public Map getHeaders() {
1919
return headers;
2020
}
2121

22-
public void setHeaders(Map<String, String> headers) {
22+
public void setHeaders(Map headers) {
2323
this.headers = headers;
2424
}
2525

@@ -31,11 +31,11 @@ public void setMethod(String method) {
3131
this.method = method;
3232
}
3333

34-
public Map<String, String> getQuery() {
34+
public Map getQuery() {
3535
return query;
3636
}
3737

38-
public void setQuery(Map<String, String> query) {
38+
public void setQuery(Map query) {
3939
this.query = query;
4040
}
4141

@@ -63,11 +63,11 @@ public void setPath(String path) {
6363
this.path = path;
6464
}
6565

66-
public Map<String, ?> getData() {
66+
public Map getData() {
6767
return data;
6868
}
6969

70-
public void setData(Map<String, ?> data) {
70+
public void setData(Map data) {
7171
this.data = data;
7272
}
7373
}

src/main/java/com/meituan/lyrebird/client/api/Response.java

+6-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.meituan.lyrebird.client.api;
22

3-
import java.util.HashMap;
43
import java.util.Map;
54

65
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
@@ -9,8 +8,8 @@
98
@JsonIgnoreProperties(ignoreUnknown = true)
109
public class Response {
1110
private int code;
12-
private Map<String, String> headers = new HashMap<>();
13-
private Map<String, ?> data = new HashMap<>();
11+
private Map headers;
12+
private Map data;
1413

1514
public int getCode() {
1615
return code;
@@ -20,11 +19,11 @@ public void setCode(int code) {
2019
this.code = code;
2120
}
2221

23-
public Map<String, String> getHeaders() {
22+
public Map getHeaders() {
2423
return headers;
2524
}
2625

27-
public void setHeaders(Map<String, String> headers) {
26+
public void setHeaders(Map headers) {
2827
this.headers = headers;
2928
}
3029

@@ -33,7 +32,7 @@ public void setHeaders(Map<String, String> headers) {
3332
*
3433
* @return 服务端返回数据映射的 Java 对象
3534
*/
36-
public Map<String, ?> getData() {
35+
public Map getData() {
3736
return data;
3837
}
3938

@@ -60,7 +59,7 @@ public <T> T getData(String jsonPath, Class<T> type) {
6059
return JsonPath.parse(data).read(jsonPath, type);
6160
}
6261

63-
public void setData(Map<String, ?> data) {
62+
public void setData(Map data) {
6463
this.data = data;
6564
}
6665
}

src/test/java/com/meituan/lyrebird/test/TestFunctional.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void testFlowRequest() throws LyrebirdClientException {
110110
FlowDetail flow = this.lyrebird.getFlowDetail("67ea0002-9566-41db-8178-ca0c2f82a71a");
111111

112112
assertEquals("tester", flow.getRequest().getQuery().get("name"));
113-
assertEquals(null, flow.getRequest().getData().get("age"));
113+
assertEquals(null, flow.getRequest().getData());
114114
assertEquals("http://www.lyrebird.java.client.com/api/example", flow.getRequest().getUrl());
115115
}
116116

0 commit comments

Comments
 (0)