NanoMips: Add option to disable BALC opt in linker

Added an option to disable BALC stubs optimization from llc. Added a test case for this change, changed addr.ll test as it was failing due to this change.

Author: Djordje Todorovic

llvm/lib/Target/Mips/MipsAsmPrinter.cpp

@@ -72,6 +72,11 @@ using namespace llvm;
 
 extern cl::opt<bool> EmitJalrReloc;
 
+static cl::opt<bool> DisableNanoMipsBalcStubs(
+    "disable-nanomips-balc-stubs", cl::Hidden,
+    cl::desc("NANOMIPS: Disable balc stubs optimization in the linker"),
+    cl::init(false));
+
 void MipsAsmPrinter::emitJumpTableInfo() {
   if (!Subtarget->hasNanoMips() || Subtarget->useAbsoluteJumpTables() ) {
     AsmPrinter::emitJumpTableInfo();
@@ -409,6 +414,18 @@ void MipsAsmPrinter::emitLoadAddressNM(MCStreamer &OutStreamer,
   LA.addOperand(Addr);
   EmitToStreamer(OutStreamer, LA);
 }
+// NOTE: This is being used to control optimization of BALC in the linker.
+static void emitDirectivesToDisableBalcStubs(const MachineInstr &MI,
+                                            MCContext &OutContext,
+                                            TargetMachine &TM,
+                                            MCStreamer &OutStreamer) {
+  assert(DisableNanoMipsBalcStubs || !MI.getMF()->getFunction().hasOptSize());
+  MCSymbol *OffsetLabel = OutContext.createTempSymbol();
+  const MCExpr *OffsetExpr = MCSymbolRefExpr::create(OffsetLabel, OutContext);
+  OutStreamer.emitRelocDirective(*OffsetExpr, "R_NANOMIPS_NOTRAMP", nullptr,
+                                 SMLoc(), *TM.getMCSubtargetInfo());
+  OutStreamer.emitLabel(OffsetLabel);
+}
 
 void MipsAsmPrinter::emitInstruction(const MachineInstr *MI) {
   // FIXME: Enable feature predicate checks once all the test pass.
@@ -525,6 +542,11 @@ void MipsAsmPrinter::emitInstruction(const MachineInstr *MI) {
       continue;
     }
 
+    if (Subtarget->hasNanoMips() && I->getOpcode() == Mips::BALC_NM &&
+        (!I->getMF()->getFunction().hasOptSize() || DisableNanoMipsBalcStubs)) {
+      emitDirectivesToDisableBalcStubs(*I, OutContext, TM, *OutStreamer);
+    }
+
     // The inMips16Mode() test is not permanent.
     // Some instructions are marked as pseudo right now which
     // would make the test fail for the wrong reason but

llvm/test/CodeGen/Mips/nanomips/addr.ll

@@ -3,7 +3,7 @@
 
 @b = external dso_local local_unnamed_addr global [0 x i32], align 4
 
-define dso_local void @foo(i32* nocapture readonly %a) local_unnamed_addr {
+define dso_local void @foo(i32* nocapture readonly %a) local_unnamed_addr optsize {
 ; CHECK-LABEL: foo:
 ; CHECK:       # %bb.0: # %entry
 ; CHECK-NEXT:    save 16, $ra
@@ -25,7 +25,7 @@ entry:
 
 declare dso_local void @sink(i32 signext, i32 signext) local_unnamed_addr
 
-define dso_local void @bar() local_unnamed_addr {
+define dso_local void @bar() local_unnamed_addr optsize {
 ; CHECK-LABEL: bar:
 ; CHECK:       # %bb.0: # %entry
 ; CHECK-NEXT:    save 16, $ra

llvm/test/CodeGen/Mips/nanomips/disable-balc-stubs.ll

@@ -0,0 +1,39 @@
+; Should enable REQUIRES: nanomips
+; ModuleID = 'disable-balc-stubs.c'
+source_filename = "disable-balc-stubs.c"
+target datalayout = "e-m:e-p:32:32-i8:8:32-i16:16:32-i64:64-n32:64-S128"
+target triple = "nanomips"
+
+; RUN: llc %s -o - | FileCheck %s
+; RUN: llc %s --disable-nanomips-balc-stubs -o - | FileCheck %s --check-prefix=CHECK-DISABLED
+
+
+; Function Attrs: noinline nounwind optnone
+define dso_local void @y() #0 {
+entry:
+  ret void
+}
+
+; Function Attrs: noinline nounwind optsize
+; CHECK: f:
+; CHECK-DISABLED: f:
+define dso_local void @f() #1 {
+entry:
+  ; CHECK-NOT: R_NANOMIPS_NOTRAMP
+  ; CHECK-DISABLED: R_NANOMIPS_NOTRAMP 
+  call void @y()
+  ret void
+}
+
+; Function Attrs: noinline nounwind optnone
+; CHECK: g:
+; CHECK-DISABLED: g:
+define dso_local void @g() #0 {
+entry:
+  ; CHECK: R_NANOMIPS_NOTRAMP
+  call void @y()
+  ret void
+}
+
+attributes #0 = { noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="i7200" "target-features"="+i7200,+pcrel,+relax,+soft-float,-noabicalls" "use-soft-float"="true" }
+attributes #1 = { noinline nounwind optsize "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="i7200" "target-features"="+i7200,+pcrel,+relax,+soft-float,-noabicalls" "use-soft-float"="true" }