Add various configuration components #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Ramsey
force-pushed
the
components-configuration
branch
4 times, most recently
from
7ebfae7 to
1bd7e54
Compare
Harry-Ramsey
force-pushed
the
components-configuration
branch
from
1bd7e54 to
815aac7
Compare
Harry-Ramsey
force-pushed
the
components-configuration
branch
from
815aac7 to
c9df6f6
Compare
Harry-Ramsey
force-pushed
the
components-configuration
branch
from
c9df6f6 to
4666429
Compare
Harry-Ramsey
force-pushed
the
components-configuration
branch
5 times, most recently
from
89d9656 to
795636d
Compare
ronald-cron-arm
requested changes
Feb 20, 2025
Harry-Ramsey
removed
needs-preceding-pr
Harry-Ramsey
force-pushed
the
components-configuration
branch
3 times, most recently
from
776dd16 to
1c7c66a
Compare
ronald-cron-arm
added
enhancement
| ################################################################ | ||
|
|
||
| component_tf_psa_crypto_test_default_out_of_box () { | ||
| msg "build: make, default config (out-of-box)" # ~1min |
There was a problem hiding this comment.
I think it should be:
Suggested change
| msg "build: make, default config (out-of-box)" # ~1min | |
| msg "build: cmake, default config (out-of-box)" # ~1min |
but actually I have a question about this: specifying cmake made sense in the main repo because there you can either build with make or cmake, but in tf-psa-crypto there's only 1 option and that's cmake. Can't we just fix all the message strings in this file by removing cmake?
There was a problem hiding this comment.
Yeah, I think that is a better solution since it is just not necessary in a single build system project.
Comment on lines
96
to
98
| # TF-M configuration needs a TF-M platform. A tweaked version of | ||
| # the configuration that works on mainstream platforms is in | ||
| # configs/config-tfm.h, tested via test-ref-configs.pl. |
There was a problem hiding this comment.
I think that the last part of this sentence should be removed:
Suggested change
| # TF-M configuration needs a TF-M platform. A tweaked version of | |
| # the configuration that works on mainstream platforms is in | |
| # configs/config-tfm.h, tested via test-ref-configs.pl. | |
| # TF-M configuration needs a TF-M platform. |
because it looks like a leftover from when this test component is executed from the main repo. In the tf-psa-crypto there's no configs/config-tfm.h as far as I can see.
valeriosetti
requested changes
Feb 21, 2025
Harry-Ramsey
force-pushed
the
components-configuration
branch
from
1c7c66a to
055e3c5
Compare
ronald-cron-arm
requested changes
Feb 21, 2025
Harry-Ramsey
force-pushed
the
components-configuration
branch
from
74d8a64 to
784627d
Compare
valeriosetti
approved these changes
Feb 21, 2025
ronald-cron-arm
added
approved
Harry-Ramsey
force-pushed
the
components-configuration
branch
from
784627d to
aaf836a
Compare
Restore test crypto configuration files in the state they were in Mbed TLS just before the split as in the merge of PR 9809, commit Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the documentation for user-config-for-test.h due to it being moved to TF-PSA-Crypto. Signed-off-by: Harry Ramsey <[email protected]>
This commit adds various configuration components to TF-PSA-Crypto. These components have been adapted from Mbed TLS to use CMake. Signed-off-by: Harry Ramsey <[email protected]>
This commit adds a new cmake flag to the build_tfm component in components-configuration.sh. The purpose of the flag is to disable CMake compiler tests since it will always try to build an executable which will always fail on linking due to architecture mismatch. Signed-off-by: Harry Ramsey <[email protected]>
This commit removes multiple unnecessary C flags from components-configuration and replaces some with CMake build types. Signed-off-by: Harry Ramsey <[email protected]>
This commit adds a new component test_default_no_deprecated to components-configuration.sh. Signed-off-by: Harry Ramsey <[email protected]>
This commit removes references to cmake in the echo messages since TF-PSA-Crypto has only a CMake build system. Signed-off-by: Harry Ramsey <[email protected]>
ronald-cron-arm
force-pushed
the
components-configuration
branch
from
aaf836a to
7a8ff01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds various configuration components to TF-PSA-Crypto. These components have been adapted from Mbed TLS to use CMake. Closes #125.
This pull request has a dependency on: #164
PR checklist