Skip to content

Commit faed6c7

Browse files
committed
Refactor RSACryptoServiceProviderTest to use class properties for passphrase and salt, improving code readability and maintainability
1 parent 47b9f1c commit faed6c7

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tests/RSACryptoServiceProviderTest.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,34 +9,37 @@
99

1010
class RSACryptoServiceProviderTest extends TestCase
1111
{
12+
protected string $salt = 'salt';
13+
protected string $passphrase = 'passphrase';
14+
1215
/** @test */
1316
public function canEncryptAndDecryptText()
1417
{
1518
$plainText = "This is going to be encrypted!";
1619
$parameters = new RSAParameters();
17-
$parameters->generateKeys("passphrase");
20+
$parameters->generateKeys(passphrase: $this->passphrase, salt: $this->salt);
1821

1922
$rsa = new RSACryptoServiceProvider();
2023
$rsa->setParameters($parameters);
2124
$encryptedTest = $rsa->encrypt($plainText);
2225

23-
$this->assertEquals($plainText, $rsa->decrypt($encryptedTest));
26+
$this->assertEquals($plainText, $rsa->decrypt($encryptedTest, privateKeyPass: $this->passphrase, salt: $this->salt));
2427
}
2528

2629
/** @test */
2730
public function canSealData()
2831
{
2932
$plainText = "This is going";
3033
$parameters = new RSAParameters();
31-
$parameters->generateKeys("passphrase");
34+
$parameters->generateKeys(passphrase: $this->passphrase, salt: $this->salt);
3235

3336
$rsa = new RSACryptoServiceProvider();
3437
$rsa->setParameters($parameters);
3538

3639
$aes = new AESCryptoServiceProvider();
3740

3841
$sealed = $aes->seal($plainText, $parameters, humanReadableData: true);
39-
$opened = $aes->open($sealed[1], $sealed[0], $parameters);
42+
$opened = $aes->open($sealed[1], $sealed[0], $parameters, $this->passphrase, $this->salt);
4043

4144
$this->assertEquals($plainText, $opened);
4245
}

0 commit comments

Comments
 (0)