New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit opt-out for error swallowing #29

Open

MatteoGioioso opened this issue Dec 2, 2020 · 0 comments

Labels

enhancement good first issue help wanted

Owner

MatteoGioioso commented Dec 2, 2020 •

edited

Loading

Might be better to add an explicit opt-out to swallow internal errors:

} catch (e){
    if(this._config.errorSwallow){
       this._logger("Swallowed internal error", e.message)
       // Swallow the error, if this produce an error there is no need to error the function

      return {
        rows: []
     }
   } else {
    throw e
  }
}

MatteoGioioso added enhancement help wanted good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment