Turn off enable_frontend_peek_sequencing in CI for now
#34279
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
approved these changes
Nov 25, 2025
Contributor
def-
left a comment
def-
left a comment
There was a problem hiding this comment.
I'm guessing this is what made the benchmarks red: https://buildkite.com/materialize/nightly/builds/14186
Contributor
Author
|
Indeed, sorry for that! Some benchmarks are currently slower if the flag is on, because for many statement types we first try the frontend peek sequencing, and then fall back to the old peek sequencing, which starts over, so we end up doing more work in total. (This problem will go away when we reach he point where we never fall back to the old peek sequencing if the flag is on.) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, my plan is to keep this off in CI on
mainfor now. That is, I'll just temporarily enable it for every PR, but then remove the enabling commit from the PR just before merging the PR. (And then I'll make it default to on in CI when we are closer to rolling it out.)Unfortunately, I forgot to remove the commit before merging #34238 🤦. So, this PR just turns it back off.