[persist] Don't discard parts that should be deleted #30941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
mark_consumed
drops all the parts in the batch, so the rest of this method's logic didn't do anything.Motivation
Bug! First reported in Slack.
Tips for reviewer
The slack thread also suggests that
compare_and_append_batch
should take ownership of the data. I've taken a look at this, but it's going to be a more substantial change... still seems worth doing, but better as a followup.This also includes a simple regression test.
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.