Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[persist] Don't discard parts that should be deleted #30941

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Jan 3, 2025

Calling mark_consumed drops all the parts in the batch, so the rest of this method's logic didn't do anything.

Motivation

Bug! First reported in Slack.

Tips for reviewer

The slack thread also suggests that compare_and_append_batch should take ownership of the data. I've taken a look at this, but it's going to be a more substantial change... still seems worth doing, but better as a followup.

This also includes a simple regression test.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

bkirwi added 2 commits January 3, 2025 13:39
Mark-consumed discards the parts, so this method was a noop in all
cases. Oops!
@bkirwi bkirwi marked this pull request as ready for review January 3, 2025 19:32
@bkirwi bkirwi requested a review from a team as a code owner January 3, 2025 19:32
@bkirwi
Copy link
Contributor Author

bkirwi commented Jan 3, 2025

@bkirwi bkirwi merged commit 93018b6 into MaterializeInc:main Jan 6, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants