For release, do not treat warnings as errors

Author: MartinHelmut

.github/workflows/release.yml

@@ -2,9 +2,9 @@ name: Release
 
 on:
   push:
-    branches: [ "main" ]
+    branches: ["main"]
   pull_request:
-    branches: [ "main" ]
+    branches: ["main"]
 
 env:
   BUILD_TYPE: Release
@@ -13,15 +13,15 @@ jobs:
   build:
     strategy:
       matrix:
-        os: [ macos-14, ubuntu-latest, windows-latest ]
+        os: [macos-14, ubuntu-latest, windows-latest]
 
     runs-on: ${{ matrix.os }}
 
     steps:
       - uses: actions/checkout@v4
 
       - name: Configure CMake
-        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DWARNINGS_AS_ERRORS=FALSE
 
       - name: Build
         run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}

CMakePresets.json

@@ -16,7 +16,8 @@
       "generator": "Ninja",
       "binaryDir": "build/release",
       "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "Release"
+        "CMAKE_BUILD_TYPE": "Release",
+        "WARNINGS_AS_ERRORS": "FALSE"
       }
     },
     {
@@ -41,7 +42,8 @@
       "binaryDir": "build/xcode-release",
       "cacheVariables": {
         "CMAKE_BUILD_TYPE": "Release",
-        "CMAKE_OSX_ARCHITECTURES": "x86_64;arm64"
+        "CMAKE_OSX_ARCHITECTURES": "x86_64;arm64",
+        "WARNINGS_AS_ERRORS": "FALSE"
       },
       "condition": {
         "type": "equals",
@@ -62,9 +64,7 @@
       "displayName": "Build Release",
       "configurePreset": "release",
       "configuration": "Release",
-      "targets": [
-        "App"
-      ]
+      "targets": ["App"]
     },
     {
       "name": "xcode-debug",
@@ -82,9 +82,7 @@
       "displayName": "Build Release (Xcode)",
       "configurePreset": "xcode-release",
       "configuration": "Release",
-      "targets": [
-        "App"
-      ],
+      "targets": ["App"],
       "condition": {
         "type": "equals",
         "lhs": "${hostSystemName}",
@@ -97,17 +95,13 @@
       "name": "release",
       "displayName": "Distribute Release",
       "configurePreset": "release",
-      "configurations": [
-        "Release"
-      ]
+      "configurations": ["Release"]
     },
     {
       "name": "xcode-release",
       "displayName": "Distribute Release (Xcode)",
       "configurePreset": "xcode-release",
-      "configurations": [
-        "Release"
-      ],
+      "configurations": ["Release"],
       "condition": {
         "type": "equals",
         "lhs": "${hostSystemName}",

cmake/CompilerWarnings.cmake

@@ -2,7 +2,6 @@
 
 function(set_project_warnings project_name)
   option(WARNINGS_AS_ERRORS "Treat compiler warnings as errors" TRUE)
-  message(STATUS "Treat compiler warnings as errors")
 
   set(MSVC_WARNINGS
     /W4 # Baseline reasonable warnings
@@ -59,6 +58,7 @@ function(set_project_warnings project_name)
     )
 
   if (WARNINGS_AS_ERRORS)
+    message(STATUS "Treat compiler warnings as errors")
     set(CLANG_WARNINGS ${CLANG_WARNINGS} -Werror)
     set(MSVC_WARNINGS ${MSVC_WARNINGS} /WX)
   endif ()