Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for videos #29

Closed
greg0ire opened this issue Jan 10, 2025 · 4 comments · Fixed by #30
Closed

Support for videos #29

greg0ire opened this issue Jan 10, 2025 · 4 comments · Fixed by #30
Assignees
Labels
bug Something isn't working

Comments

@greg0ire
Copy link
Contributor

I've been trying to use the following video tag:

<video controls preload="metadata">
    <source src="node.webm" type="video/webm"/>
    Video not supported.
</video>

When I try that, Firefox says "No video with supported format and MIME type found".
When I inspect and click "open in a new tab", http://localhost:8000/node.webm opens, but it's a 404

I think it would be great if it worked the same was as it works for img, where images get served as expected.

@MartenBE MartenBE self-assigned this Jan 10, 2025
@MartenBE MartenBE added the bug Something isn't working label Jan 10, 2025
@MartenBE
Copy link
Owner

I am taking another approach to copy everything in the docs folder due to #6 and #27, but I'll see if I can get a hotfix implemented for now so you don't have to wait for the large overhaul

@MartenBE MartenBE linked a pull request Jan 12, 2025 that will close this issue
@MartenBE MartenBE reopened this Jan 12, 2025
@MartenBE
Copy link
Owner

Fix went quicker than expected. PR #30 has been merged, and is included in v1.0.3 (latest)

@greg0ire
Copy link
Contributor Author

Oh wow! Thanks! I'll try that rightaway!

@greg0ire
Copy link
Contributor Author

It works! Awesome job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants