GetBrowserCatalog to use Response.Json (#345)

* GetBrowserCatalog to use Response.Json

* Fixed accidental change

* Removed not used stringResponse

* Update playwright-state.ts

Author: aaltat

Browser/keywords/playwright_state.py

@@ -393,7 +393,7 @@ def get_browser_catalog(self):
         """
         with self.playwright.grpc_channel() as stub:
             response = stub.GetBrowserCatalog(Request().Empty())
-            parsed = json.loads(response.body)
+            parsed = json.loads(response.json)
             logger.info(json.dumps(parsed))
             return parsed
 

node/playwright-wrapper/grpc-service.ts

@@ -59,7 +59,7 @@ export class PlaywrightServer implements IPlaywrightServer {
 
     async getBrowserCatalog(
         call: ServerUnaryCall<Request.Empty>,
-        callback: sendUnaryData<Response.String>,
+        callback: sendUnaryData<Response.Json>,
     ): Promise<void> {
         return playwrightState.getBrowserCatalog(callback, this.state);
     }

node/playwright-wrapper/playwright-state.ts

@@ -17,7 +17,7 @@ import { ServerUnaryCall, sendUnaryData } from 'grpc';
 import { v4 as uuidv4 } from 'uuid';
 
 import { Request, Response } from './generated/playwright_pb';
-import { emptyWithLog, stringResponse } from './response-util';
+import { emptyWithLog, jsonResponse, stringResponse } from './response-util';
 import { exists, invokeOnPage } from './playwirght-invoke';
 
 import * as pino from 'pino';
@@ -489,10 +489,9 @@ export async function switchBrowser(
 }
 
 export async function getBrowserCatalog(
-    callback: sendUnaryData<Response.String>,
+    callback: sendUnaryData<Response.Json>,
     openBrowsers: PlaywrightState,
 ): Promise<void> {
-    const response = new Response.String();
-    response.setBody(JSON.stringify(await openBrowsers.getCatalog()));
+    const response = jsonResponse(JSON.stringify(await openBrowsers.getCatalog()), 'Catalog received');
     callback(null, response);
 }

protobuf/playwright.proto

@@ -332,5 +332,5 @@ service  Playwright {
   rpc CloseAllBrowsers(Request.Empty) returns (Response.Empty);
   rpc CloseContext(Request.Empty) returns (Response.Empty);
   rpc ClosePage(Request.Empty) returns (Response.Empty);
-  rpc GetBrowserCatalog(Request.Empty) returns (Response.String);
+  rpc GetBrowserCatalog(Request.Empty) returns (Response.Json);
 }