Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require user-created structure.xml files if default child order needs to be overridden #36

Open
mjordan opened this issue Jul 27, 2018 · 4 comments
Labels

Comments

@mjordan
Copy link
Collaborator

mjordan commented Jul 27, 2018

One of this module's UX characteristics is that it requires the user to generate structure.xml files. Is there any reason why we can't make islandora_compound_batch_preprocess do that for the user? The user would only need to create structure.xml files where the default sort order for children needed to be overridden.

@mjordan
Copy link
Collaborator Author

mjordan commented Jul 27, 2018

Tagging @bondjimbond since he and I are having this discussion via email.

@mjordan
Copy link
Collaborator Author

mjordan commented Jul 27, 2018

#24 may be relevant here.

@bondjimbond
Copy link

bondjimbond commented Jul 27, 2018

Alternatively: islandora_compound_batch_preprocess could (should!) (1) check for structure.xml first, and (2) if structure.xml does not exist, automatically execute the function in create_structure_files.php on the already-set directory path as part of the preprocess.

This way, if structure.xml already exists because the user created a custom one, all proceeds happily on. If it doesn't, create it automatically, by calling the script that the user would need to run anyway.

@mjordan
Copy link
Collaborator Author

mjordan commented Jul 27, 2018

Yes, if a structure file exists, it should not be overwritten. The user would put one in the object directory it was needed, presumably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants