Skip to content

Commit 4747ef6

Browse files
committed
Clean up ShowPartial type check and remove unused parameters and atrributes in DrawBorderThenFill and fix some return types.
1 parent 3c6a1ee commit 4747ef6

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

manim/animation/creation.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def __init__(
120120
):
121121
pointwise = getattr(mobject, "pointwise_become_partial", None)
122122
if not callable(pointwise):
123-
raise NotImplementedError("This animation is not defined for this Mobject.")
123+
raise TypeError(f"{self.__class__.__name__} only works for VMobjects.")
124124
super().__init__(mobject, **kwargs)
125125

126126
def interpolate_submobject(
@@ -133,7 +133,7 @@ def interpolate_submobject(
133133
starting_submobject, *self._get_bounds(alpha)
134134
)
135135

136-
def _get_bounds(self, alpha: float) -> None:
136+
def _get_bounds(self, alpha: float) -> tuple[float, float]:
137137
raise NotImplementedError("Please use Create or ShowPassingFlash")
138138

139139

@@ -173,7 +173,7 @@ def __init__(
173173
) -> None:
174174
super().__init__(mobject, lag_ratio=lag_ratio, introducer=introducer, **kwargs)
175175

176-
def _get_bounds(self, alpha: float) -> tuple[int, float]:
176+
def _get_bounds(self, alpha: float) -> tuple[float, float]:
177177
return (0, alpha)
178178

179179

@@ -229,8 +229,6 @@ def __init__(
229229
rate_func: Callable[[float], float] = double_smooth,
230230
stroke_width: float = 2,
231231
stroke_color: str = None,
232-
draw_border_animation_config: dict = {}, # what does this dict accept?
233-
fill_animation_config: dict = {},
234232
introducer: bool = True,
235233
**kwargs,
236234
) -> None:
@@ -244,8 +242,6 @@ def __init__(
244242
)
245243
self.stroke_width = stroke_width
246244
self.stroke_color = stroke_color
247-
self.draw_border_animation_config = draw_border_animation_config
248-
self.fill_animation_config = fill_animation_config
249245
self.outline = self.get_outline()
250246

251247
def _typecheck_input(self, vmobject: VMobject | OpenGLVMobject) -> None:

0 commit comments

Comments
 (0)