Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Database Backups from core (move to appliance console) #21100

Closed
14 of 15 tasks
NickLaMuro opened this issue Mar 9, 2021 · 6 comments
Closed
14 of 15 tasks

Remove Database Backups from core (move to appliance console) #21100

NickLaMuro opened this issue Mar 9, 2021 · 6 comments
Assignees
Milestone

Comments

@NickLaMuro
Copy link
Member

NickLaMuro commented Mar 9, 2021

For containers, we have a different process for doing database backups that doesn't make sense in appliance distributions of MIQ.

So it doesn't make to have a completely different process maintained in the core code base to handle backups, as well as having a toggle switch of sorts in the UI to disable database backups from being shown when in a container deployment.

As such, we are moving the responsibility of database backups to simply be a manageiq-appliance_console concern, and removing the need for the application (and the code base) to manage it.

In the process, we will also simplify the scope of responsibility to return to database backups only being done to a file location mounted on the system, which the user will have to setup themselves. This shouldn't remove the ability for connecting to S3, for example, as their are options like s3fs-fuse available for connecting to s3 via a mount, and for the other providers we have setup support for, options should be available for them as well. It does require a few more steps, but for a system admin this shouldn't be too much of an ask when compared with database backup management that already isn't handled by ManageIQ.

TODO

@NickLaMuro NickLaMuro modified the milestone: Morphy Mar 9, 2021
@Fryguy Fryguy added this to the Morphy milestone Mar 9, 2021
@Fryguy
Copy link
Member

Fryguy commented Mar 9, 2021

@NickLaMuro I wonder if we should a bullet for creating documentation for the current set of targets (e.g. explaining how to mount an s3fs-fuse mountpoint), or perhaps even just a subset of the more common ones.

@NickLaMuro
Copy link
Member Author

Sure, I am cool with that idea. Will add.

@NickLaMuro
Copy link
Member Author

NickLaMuro commented Mar 30, 2021

Doesn't really fit into a bullet item, but I have created a repo I am using currently to test the appliance_console backups in a mostly automated fashion.

https://github.com/NickLaMuro/manageiq-db_backup-tests

It is a bit unwieldy to use so that is why it currently lives under my account, but am happy to move it somewhere that makes more sense. Also, the README is a bit outdated, so ignore that for the time being...

@Fryguy
Copy link
Member

Fryguy commented Jul 30, 2021

I didn't see any entry for the now-merged ManageIQ/manageiq-appliance_console#161 in the OP, but I wasn't sure where to add it.

Also, we need a release of the manageiq-appliance_console gem and possibly a bump for it in https://github.com/ManageIQ/manageiq-appliance/blob/master/manageiq-appliance-dependencies.rb

@NickLaMuro
Copy link
Member Author

cc @bdunne ^

@bdunne
Copy link
Member

bdunne commented Aug 3, 2021

Also, we need a release of the manageiq-appliance_console gem

I'll release a new version once we merge ManageIQ/manageiq-appliance_console#165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Najdorf
Development

No branches or pull requests

4 participants