-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Database Backups from core (move to appliance console) #21100
Comments
@NickLaMuro I wonder if we should a bullet for creating documentation for the current set of targets (e.g. explaining how to mount an s3fs-fuse mountpoint), or perhaps even just a subset of the more common ones. |
Sure, I am cool with that idea. Will add. |
Doesn't really fit into a bullet item, but I have created a repo I am using currently to test the https://github.com/NickLaMuro/manageiq-db_backup-tests It is a bit unwieldy to use so that is why it currently lives under my account, but am happy to move it somewhere that makes more sense. Also, the README is a bit outdated, so ignore that for the time being... |
I didn't see any entry for the now-merged ManageIQ/manageiq-appliance_console#161 in the OP, but I wasn't sure where to add it. Also, we need a release of the manageiq-appliance_console gem and possibly a bump for it in https://github.com/ManageIQ/manageiq-appliance/blob/master/manageiq-appliance-dependencies.rb |
cc @bdunne ^ |
I'll release a new version once we merge ManageIQ/manageiq-appliance_console#165 |
For containers, we have a different process for doing database backups that doesn't make sense in appliance distributions of MIQ.
So it doesn't make to have a completely different process maintained in the core code base to handle backups, as well as having a toggle switch of sorts in the UI to disable database backups from being shown when in a container deployment.
As such, we are moving the responsibility of database backups to simply be a
manageiq-appliance_console
concern, and removing the need for the application (and the code base) to manage it.In the process, we will also simplify the scope of responsibility to return to database backups only being done to a file location mounted on the system, which the user will have to setup themselves. This shouldn't remove the ability for connecting to S3, for example, as their are options like
s3fs-fuse
available for connecting to s3 via a mount, and for the other providers we have setup support for, options should be available for them as well. It does require a few more steps, but for a system admin this shouldn't be too much of an ask when compared with database backup management that already isn't handled by ManageIQ.TODO
PostgresAdmin
out ofmanageiq-gems-pending
(not being used else where)/schedulingmenu inmanageiq-appliance_console
run_rake
and just callPostgresAdmin
directlymanageiq-appliance-console
manageiq-appliance-dependencies
FileDepot
code inmanageiq
(might need to remove log backups as well)FileStorage
code inmanageiq-gems-pending
(will no longer be used)DatabaseBackup
andEvmDatabaseOps
codemanageiq-appliance_console
The text was updated successfully, but these errors were encountered: