Merge pull request #34 from elsupergomez/fix-warning

Fix warning

Author: RodrigoPereyraDiaz

src/MakingSense.AspNetCore.HypermediaApi/ApiMappers/ApiMapperExtensions.cs

@@ -59,18 +59,16 @@ public static TOut Map<TIn, TOut>(this IApiMapper<TIn, TOut> mapper, TIn input)
 		public static IEnumerable<TOut> Map<TIn, TOut>(this IApiMapper<TIn, TOut> mapper, IEnumerable<TIn> inputEnumerable)
 			where TOut : class, new()
 		{
-			var queryableProyector = mapper as IQueryableMapper<TIn, TOut>;
 			return
-				queryableProyector != null ? queryableProyector.Map(inputEnumerable.AsQueryable())
+				mapper is IQueryableMapper<TIn, TOut> queryableProyector ? queryableProyector.Map(inputEnumerable.AsQueryable())
 				: inputEnumerable.Select(x => mapper.Map(x));
 		}
 
 		public static IEnumerable<TOut> Map<TIn, TOut>(this IApiMapper<TIn, TOut> mapper, IQueryable<TIn> inputQueryable)
 			where TOut : class, new()
 		{
-			var queryableProyector = mapper as IQueryableMapper<TIn, TOut>;
 			return
-				queryableProyector != null ? queryableProyector.Map(inputQueryable)
+				mapper is IQueryableMapper<TIn, TOut> queryableProyector ? queryableProyector.Map(inputQueryable)
 				: inputQueryable.AsEnumerable().Select(x => mapper.Map(x));
 		}
 

src/MakingSense.AspNetCore.HypermediaApi/Formatters/HypermediaApiJsonInputFormatter.cs

@@ -1,8 +1,6 @@
 using System;
 using System.Buffers;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
+using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Mvc.Formatters;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.ObjectPool;
@@ -17,8 +15,14 @@ public class HypermediaApiJsonInputFormatter : JsonInputFormatter
 
 		public bool AcceptAnyContentType { get; set; } = false;
 
+		[Obsolete("This constructor is obsolete and will be removed in a future version.")]
 		public HypermediaApiJsonInputFormatter(ILogger logger, JsonSerializerSettings serializerSettings, ArrayPool<char> charPool, ObjectPoolProvider objectPoolProvider)
-			: base(logger, serializerSettings, charPool, objectPoolProvider)
+			: this(logger, serializerSettings, charPool, objectPoolProvider, null, null)
+		{
+		}
+
+		public HypermediaApiJsonInputFormatter(ILogger logger, JsonSerializerSettings serializerSettings, ArrayPool<char> charPool, ObjectPoolProvider objectPoolProvider, MvcOptions options, MvcJsonOptions jsonOptions)
+			: base(logger, serializerSettings, charPool, objectPoolProvider, options, jsonOptions)
 		{
 			//TODO: add a setting to strict case sensitive de-serialization for properties
 

src/MakingSense.AspNetCore.HypermediaApi/Formatters/Internal/HypermediaApiMvcOptionsSetup.cs

@@ -1,8 +1,5 @@
 using System;
 using System.Buffers;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Mvc.Formatters;
 using Microsoft.Extensions.Logging;
@@ -24,7 +21,8 @@ public HypermediaApiMvcOptionsSetup(
 				jsonOptions.Value.SerializerSettings,
 				loggerFactory,
 				charPool,
-				objectPoolProvider))
+				objectPoolProvider,
+				jsonOptions.Value))
 		{
 		}
 
@@ -33,7 +31,8 @@ public static void ConfigureMvc(
 			JsonSerializerSettings serializerSettings,
 			ILoggerFactory loggerFactory,
 			ArrayPool<char> charPool,
-			ObjectPoolProvider objectPoolProvider)
+			ObjectPoolProvider objectPoolProvider,
+			MvcJsonOptions jsonOptions = null)
 		{
 			serializerSettings.Formatting = Formatting.Indented;
 
@@ -49,7 +48,9 @@ public static void ConfigureMvc(
 				jsonInputLogger,
 				serializerSettings,
 				charPool,
-				objectPoolProvider));
+				objectPoolProvider,
+				options,
+				jsonOptions));
 		}
 	}
 }

src/MakingSense.AspNetCore.HypermediaApi/Linking/BaseLinkHelper.cs

@@ -67,10 +67,9 @@ public Maybe<Link> ToAction(MethodInfo method, ReadOnlyCollection<Expression> ar
 			var wrappedValues = Enumerable.Range(0, arguments.Count).Select(x =>
 			{
 				var argument = arguments[x];
-				var unaryExpression = argument as UnaryExpression;
 				TemplateParameter value;
 
-				if (unaryExpression != null && unaryExpression.Operand.Type.GetTypeInfo().IsSubclassOf(typeof(TemplateParameter)))
+				if (argument is UnaryExpression unaryExpression && unaryExpression.Operand.Type.GetTypeInfo().IsSubclassOf(typeof(TemplateParameter)))
 				{
 					value = Expression.Lambda(unaryExpression.Operand).Compile().DynamicInvoke() as TemplateParameter;
 				}

src/MakingSense.AspNetCore.HypermediaApi/ValidationFilters/RequiredPayloadFilter.cs

@@ -22,8 +22,7 @@ public void OnActionExecuting([NotNull]ActionExecutingContext context)
 		{
 			if (context.ModelState.IsValid)
 			{
-				var actionDescriptor = context.ActionDescriptor as ControllerActionDescriptor;
-				if (actionDescriptor == null)
+				if (!(context.ActionDescriptor is ControllerActionDescriptor actionDescriptor))
 				{
 					return;
 				}