Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more useful examples & chain actions #30

Open
Akronae opened this issue Jun 2, 2024 · 0 comments
Open

Show more useful examples & chain actions #30

Akronae opened this issue Jun 2, 2024 · 0 comments

Comments

@Akronae
Copy link

Akronae commented Jun 2, 2024

Hi,

I think the sample shown to get started could be improved with something actually usable like so:

name: Create a new release on `package.json#version` bump

on:
  push:
    branches:
      - main

jobs:
  release-on-version-bump:
    permissions: write-all
    runs-on: ubuntu-latest
    steps:
      - uses: Makepad-fr/[email protected]
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          name: "$newVersion"
          body: "✨ New release $newVersion"
          draft: "false"
          pre-release: "auto"
          generate-release-note: "true"
          tag-name: "$newVersion"

trigger, jobs and permission were missing, and the action name was wrong.

Last thing, do you know how to have some other action run when this action creates a new release?
I have another action of this sort

name: Publish Package to yarn

on:
  release:
    types: [published]

But it does not get triggered when auto-release-on-version-bump-action creates a new release.

Thanks for your action its great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant