Fix closing of connection discarded by session target attrs (#1046)

elprans · web-flow · commit 6043d9136511 · 2023-07-06T16:53:47.000-07:00
`asyncio.gather` takes a variadic, not an iterable and
`return_exceptions` was masking the issue.
diff --git a/asyncpg/connect_utils.py b/asyncpg/connect_utils.py
@@ -1003,7 +1003,7 @@ async def _connect(*, loop, timeout, connection_class, record_class, **kwargs):
             chosen_connection = random.choice(candidates)
 
     await asyncio.gather(
-        (c.close() for c in candidates if c is not chosen_connection),
+        *(c.close() for c in candidates if c is not chosen_connection),
         return_exceptions=True
     )
 

Original file line number	Diff line number	Diff line change
`@@ -1003,7 +1003,7 @@ async def _connect(, loop, timeout, connection_class, record_class, *kwargs):`
`1003`	`1003`	`chosen_connection = random.choice(candidates)`
`1004`	`1004`
`1005`	`1005`	`await asyncio.gather(`
`1006`		`- (c.close() for c in candidates if c is not chosen_connection),`
	`1006`	`+ *(c.close() for c in candidates if c is not chosen_connection),`
`1007`	`1007`	`return_exceptions=True`
`1008`	`1008`	`)`
`1009`	`1009`