-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to v0.6 leads to error #52
Comments
Hi I have aded pull request with fixed error, please verify |
@MWDelaney Some people are facing issues in Sage 9. Any chance you can merge the PR that fixes this? |
@MWDelaney and @robmeijerink please verify pull request #51 before merge, in my case still it not working on sage 9, I've added #53 pull request with update, but not tested with sage 10. The path result is the same in sage_blocks_callback method line 221, so should work properly. |
Hi, I just installed this plugin and got the same error with v0.6. I decided to try v0.5 after reading through these issues and it worked fine. For anyone who is like me and looking for a workaround, v0.5 did the trick. So just install it like so:
|
I have created a pull request that fixes this issue. In the meantime, you can fix the issue by updating the template() function in helpers.php:
EDIT: my original temporary fix caused \App\template($template) to break. I added an extra condition |
This is fixed in 0.7. |
* Setup fields builder and front-page, page and component field templates * Fix bug in Sage ACF Blocks MWDelaney/sage-acf-wp-blocks#52 (comment) * Update accordion and tab components and blocks * Add blocks config file * Add automatic registration of blocks connected to component fields * Add correct version of sage blocks plugin * Add additional components and refactor existing * Add options page * Update filters, add display_sidebar * Add default BS4 gravity forms styling * Include baseline swiper styles * Refactor default layouts and templates, add kitchen sink * Update swiper language to represent carousels/sliders * Update components and kitchen sink * Add link for sage acf block fix * Remove duplicate footer element * Add CLI stubs * Add CLI script for insering dummy data into kitchen sink template * Add default card imge style * Update swiper styles * Update layout of kitchen sink page * Remove $test variable * Refactor card field structure * Programatically add a menu via demo CLI script * Add alert component and refactor quicklinks * Remove block registration and specify details in comment See #11 for more info * Update default page settings
After updating to sage-acf-wp-blocks from v0.5 to v0.6, WordPress throws an error. I haven't changed any of my blocks' syntax or location.
I also tried removing this block from my directory, but then I got the same error for the next block.
All my ACF blocks reside in
./resources/views/blocks
directory like thesage-acf-gutenberg-blocks.php
statesMy block
The text was updated successfully, but these errors were encountered: