Merge pull request #194 from MITLibraries/contribs-markup

Improve markup for contributors

Author: jazairi

app/assets/stylesheets/partials/_results.scss

@@ -107,6 +107,7 @@
     display: -webkit-box;
     -webkit-line-clamp: 3;
     -webkit-box-orient: vertical;
+    text-overflow: ellipsis;
   }
 
   .inner-heading {

app/assets/stylesheets/partials/_shared.scss

@@ -1,9 +1,18 @@
 .result,
 .full-record {
-  .authors {
+  .contributors {
     font-size: 1.6rem;
     font-weight: $fw-bold;
     margin-bottom: 0.6em;
+    li {
+      display: inline;
+    }
+    li::after {
+      content: " ; ";
+    }
+    li:last-child:after {
+      content: "";
+    }
   }
 
   .data-info {

app/views/record/_record_geo.html.erb

@@ -14,9 +14,10 @@
     </div>
 
     <% if @record['contributors'].present? %>
-      <p class="authors">
-        <%= render partial: 'shared/authors', locals: { contributors: @record['contributors'] } %>
-      </p>
+      <span class="sr">Contributors: </span>
+      <ul class="list-inline contributors">
+        <%= render partial: 'shared/contributors', locals: { contributors: @record['contributors'] } %>
+      </ul>
     <% end %>
 
     <% if @record['alternateTitles'].present? %>

app/views/search/_result.html.erb

@@ -12,9 +12,10 @@
     </span>
   </p>
 
-  <p class="authors">
-    <%= render partial: 'shared/authors', locals: { contributors: result['contributors'] } %>
-  </p>
+  <span class="sr">Contributors: </span>
+  <ul class="list-inline truncate-list contributors">
+    <%= render partial: 'shared/contributors', locals: { contributors: result['contributors'] } %>
+  </ul>
 
   <div class="result-highlights">
     <%= render partial: 'search/highlights', locals: { result: result } %>

app/views/search/_result_geo.html.erb

@@ -8,9 +8,10 @@
   </div>
 
   <% if result_geo['contributors'] %> 
-    <p class="authors truncate-list">
-      <%= render partial: 'shared/authors', locals: { contributors: result_geo['contributors'] } %>
-    </p>
+    <span class="sr">Contributors: </span>
+    <ul class="list-inline truncate-list contributors">
+      <%= render partial: 'shared/contributors', locals: { contributors: result_geo['contributors'] } %>
+    </ul>
   <% end %>
 
   <% if result_geo['summary'] %>

app/views/shared/_contributors.html.erb

@@ -0,0 +1,5 @@
+<%= return if contributors.blank? %>
+
+<% contributors.uniq do |contributor| %>
+  <li><%= link_to contributor['value'], results_path({ advanced: true, contributors: contributor['value'] }) %></li>
+<% end %>