Merge pull request #186 from MITLibraries/gdt-297-deduplicate-subjects

Deduplicate subject values in GDT

Author: jazairi

app/helpers/record_helper.rb

@@ -124,6 +124,13 @@ def geospatial_coordinates?(locations)
     locations.any? { |location| location['geoshape'] }
   end
 
+  # It is possible for duplicate subject values to appear for the same record.
+  def deduplicate_subjects(subjects)
+    return if subjects.blank?
+
+    subjects.map { |subject| subject['value'].uniq(&:downcase) }.uniq { |values| values.map(&:downcase) }
+  end
+
   private
 
   def render_kind_value(list)

app/views/record/_record_geo.html.erb

@@ -62,8 +62,8 @@
     <% if @record['subjects'].present? %>
       <h3 class="section-title">Subjects</h3>
       <ul>
-      <% @record['subjects'].each do |subject| %>
-        <li><%= subject['value'].join('; ') %></li>
+      <% deduplicate_subjects(@record['subjects'])&.each do |subject| %>
+        <li><%= subject.join('; ') %></li>
       <% end %>
       </ul>
     <% end %>

test/helpers/record_helper_test.rb

@@ -301,4 +301,32 @@ class RecordHelperTest < ActionView::TestCase
     locations = []
     assert_not geospatial_coordinates?(locations)
   end
+
+  test 'deduplicate_subjects returns only unique subjects' do
+    # within the same subject
+    duplicative_subject = [{ 'kind' => 'foo', 'value' => ['bar', 'bar', 'baz']}]
+    assert_equal [['bar', 'baz']], deduplicate_subjects(duplicative_subject)
+
+    # across multiple subjects
+    multiple_duplicative_subjects = [{ 'kind' => 'foo', 'value' => ['bar'] },
+                                     { 'kind' => 'baz', 'value' => ['bar'] }]
+    assert_equal [['bar']], deduplicate_subjects(multiple_duplicative_subjects)
+  end
+
+  test 'deduplicate_subjects ignores case' do
+    # within the same subject
+    duplicative_subject = [{ 'kind' => 'foo', 'value' => ['Bar', 'BAR', 'bar']}]
+    assert_equal [['Bar']], deduplicate_subjects(duplicative_subject)
+
+    # across multiple subjects
+    multiple_duplicative_subjects = [{ 'kind' => 'foo', 'value' => ['Bar'] },
+                                     { 'kind' => 'foo', 'value' => ['BAR'] },
+                                     { 'kind' => 'foo', 'value' => ['bar'] }]
+    assert_equal [['Bar']], deduplicate_subjects(multiple_duplicative_subjects)
+  end
+
+  test 'deduplicate_subjects returns nothing if subjects are not present' do
+    subjects = []
+    assert_nil deduplicate_subjects(subjects)
+  end
 end