Merge pull request #251 from MITLibraries/use-96-frbr-links

Render FRBR links for Alma records only

Author: jazairi

app/models/normalize_primo_record.rb

@@ -301,8 +301,15 @@ def frbrized?
     @record['pnx']['facets']['frbrtype'].join == '5'
   end
 
+  def alma_record?
+    return false unless record_id
+
+    record_id.start_with?('alma')
+  end
+
   def dedup_url
     return unless frbrized?
+    return unless alma_record? # FRBR links do not work for CDI records
     return unless @record['pnx']['facets']['frbrgroupid'] &&
                   @record['pnx']['facets']['frbrgroupid'].length == 1
 

test/fixtures/primo/alma_record.json

@@ -0,0 +1,46 @@
+{
+  "pnx": {
+    "display": {
+      "title": ["Alma Record Testing"],
+      "creator": ["Smith, John A."],
+      "creationdate": ["2023"],
+      "type": ["book"],
+      "description": ["A test Alma record for FRBR functionality"],
+      "subject": ["Testing"]
+    },
+    "addata": {
+      "btitle": ["Alma Test Book"],
+      "date": ["2023"],
+      "volume": ["1"],
+      "issue": ["1"],
+      "pages": ["1-10"],
+      "jtitle": ["Alma Test Journal"],
+      "isbn": ["9781234567890"],
+      "pub": ["Test Press"]
+    },
+    "facets": {
+      "frbrtype": ["5"],
+      "frbrgroupid": ["alma12345"]
+    },
+    "search": {
+      "creationdate": ["2023"]
+    },
+    "control": {
+      "recordid": ["alma991234567890123456"]
+    }
+  },
+  "context": "contextual",
+  "delivery": {
+    "bestlocation": {
+      "mainLocation": "Test Library",
+      "subLocation": "Stacks",
+      "callNumber": "TEST.123 2023",
+      "availabilityStatus": "available"
+    },
+    "holding": [
+      {"location": "Main Library"}
+    ],
+    "link": [],
+    "almaOpenurl": "https://na06.alma.exlibrisgroup.com/view/uresolver/01MIT_INST/openurl?param=value"
+  }
+}

test/fixtures/primo/cdi_record.json

@@ -0,0 +1,36 @@
+{
+  "pnx": {
+    "display": {
+      "title": ["CDI Record Testing"],
+      "creator": ["Doe, Jane B."],
+      "creationdate": ["2023"],
+      "type": ["article"],
+      "description": ["A test CDI record that should not get FRBR links"],
+      "subject": ["CDI Testing"]
+    },
+    "addata": {
+      "jtitle": ["CDI Test Journal"],
+      "date": ["2023"],
+      "volume": ["2"],
+      "issue": ["3"],
+      "pages": ["15-25"],
+      "issn": ["1234-5678"],
+      "pub": ["CDI Publisher"]
+    },
+    "facets": {
+      "frbrtype": ["5"],
+      "frbrgroupid": ["cdi54321"]
+    },
+    "search": {
+      "creationdate": ["2023"]
+    },
+    "control": {
+      "recordid": ["cdi_crossref_primary_10_1234_test_article"]
+    }
+  },
+  "context": "contextual",
+  "delivery": {
+    "link": [],
+    "almaOpenurl": "https://na06.alma.exlibrisgroup.com/view/uresolver/01MIT_INST/openurl?param=value"
+  }
+}

test/fixtures/primo/full_record.json

@@ -27,7 +27,7 @@
       "creationdate": ["2023"]
     },
     "control": {
-      "recordid": ["MIT01000000001"]
+      "recordid": ["alma991000000001234567"]
     }
   },
   "context": "contextual",

test/models/normalize_primo_record_test.rb

@@ -12,6 +12,14 @@ def minimal_record
     JSON.parse(File.read(Rails.root.join('test/fixtures/primo/minimal_record.json')))
   end
 
+  def alma_record
+    JSON.parse(File.read(Rails.root.join('test/fixtures/primo/alma_record.json')))
+  end
+
+  def cdi_record
+    JSON.parse(File.read(Rails.root.join('test/fixtures/primo/cdi_record.json')))
+  end
+
   test 'normalizes title' do
     normalized = NormalizePrimoRecord.new(full_record, 'test').normalize
     assert_equal 'Testing the Limits of Knowledge', normalized['title']
@@ -95,7 +103,7 @@ def minimal_record
 
   test 'normalizes identifier' do
     normalized = NormalizePrimoRecord.new(full_record, 'test').normalize
-    assert_equal 'MIT01000000001', normalized['identifier']
+    assert_equal 'alma991000000001234567', normalized['identifier']
   end
 
   test 'normalizes summary' do
@@ -328,4 +336,91 @@ def minimal_record
     openurl_link = normalized['links'].find { |link| link['kind'] == 'openurl' }
     assert_not_nil openurl_link
   end
+
+  test 'identifies Alma records correctly' do
+    normalizer = NormalizePrimoRecord.new(alma_record, 'test')
+    assert normalizer.send(:alma_record?)
+  end
+
+  test 'identifies CDI records correctly' do
+    normalizer = NormalizePrimoRecord.new(cdi_record, 'test')
+    assert_not normalizer.send(:alma_record?)
+  end
+
+  test 'handles missing record ID for alma_record? check' do
+    record = minimal_record.deep_dup
+    normalizer = NormalizePrimoRecord.new(record, 'test')
+    assert_not normalizer.send(:alma_record?)
+  end
+
+  test 'generates FRBR dedup URL for Alma records when frbrized' do
+    normalized = NormalizePrimoRecord.new(alma_record, 'test query').normalize
+    full_record_link = normalized['links'].find { |link| link['kind'] == 'full record' }
+    assert_not_nil full_record_link
+
+    # Should use dedup URL for Alma records
+    assert_match 'frbrgroupid', full_record_link['url']
+    assert_match 'alma12345', full_record_link['url']
+  end
+
+  test 'does not generate FRBR dedup URL for CDI records even when frbrized' do
+    normalized = NormalizePrimoRecord.new(cdi_record, 'test query').normalize
+    full_record_link = normalized['links'].find { |link| link['kind'] == 'full record' }
+    assert_not_nil full_record_link
+
+    # Should use regular record link for CDI records, not dedup URL
+    assert_match %r{/discovery/fulldisplay\?}, full_record_link['url']
+    assert_no_match 'frbrgroupid', full_record_link['url']
+  end
+
+  test 'falls back to regular record link for Alma records without FRBR data' do
+    record = alma_record.deep_dup
+    record['pnx']['facets']['frbrtype'] = ['3'] # Not frbrized
+
+    normalized = NormalizePrimoRecord.new(record, 'test').normalize
+    full_record_link = normalized['links'].find { |link| link['kind'] == 'full record' }
+    assert_not_nil full_record_link
+
+    # Should use regular record link when not frbrized
+    assert_match %r{/discovery/fulldisplay\?}, full_record_link['url']
+    assert_no_match 'frbrgroupid', full_record_link['url']
+  end
+
+  test 'frbrized? method works correctly' do
+    # Frbrized Alma record
+    normalizer = NormalizePrimoRecord.new(alma_record, 'test')
+    assert normalizer.send(:frbrized?)
+
+    # Frbrized CDI record
+    normalizer = NormalizePrimoRecord.new(cdi_record, 'test')
+    assert normalizer.send(:frbrized?)
+
+    # Non-frbrized record
+    record = alma_record.deep_dup
+    record['pnx']['facets']['frbrtype'] = ['3']
+    normalizer = NormalizePrimoRecord.new(record, 'test')
+    assert_not normalizer.send(:frbrized?)
+
+    # Missing FRBR data
+    normalizer = NormalizePrimoRecord.new(minimal_record, 'test')
+    assert_not normalizer.send(:frbrized?)
+  end
+
+  test 'dedup_url requires both frbrized and alma_record conditions' do
+    # CDI record that is frbrized - should return nil
+    normalizer = NormalizePrimoRecord.new(cdi_record, 'test')
+    assert_nil normalizer.send(:dedup_url)
+
+    # Alma record that is not frbrized - should return nil
+    record = alma_record.deep_dup
+    record['pnx']['facets']['frbrtype'] = ['3']
+    normalizer = NormalizePrimoRecord.new(record, 'test')
+    assert_nil normalizer.send(:dedup_url)
+
+    # Test Alma record that is frbrized - should return URL
+    normalizer = NormalizePrimoRecord.new(alma_record, 'test')
+    dedup_url = normalizer.send(:dedup_url)
+    assert_not_nil dedup_url
+    assert_match %r{/discovery/search\?}, dedup_url
+  end
 end