🚨 Code linting

Author: HugoPerrier

tests/gmail/test_gmail.py

@@ -4,8 +4,8 @@
 import pandas as pd
 import pytest
 
-HttpRequestMock = pytest.importorskip('googleapiclient.http.HttpRequestMock')
-Credentials = pytest.importorskip('google.oauth2.credentials.Credentials')
+googleapiclient = pytest.importorskip("googleapiclient")
+from google.oauth2.credentials import Credentials
 from unittest.mock import MagicMock, patch
 
 from melusine.connectors.gmail import GmailConnector
@@ -22,10 +22,10 @@ def mocked_gc():
             with patch("melusine.connectors.gmail.os.path.exists") as mock_exists:
                 mock_exists.return_value = True
                 mock_service = MagicMock()
-                mock_service.users().getProfile.return_value = HttpRequestMock(
+                mock_service.users().getProfile.return_value = googleapiclient.http.HttpRequestMock(
                     None, {"emailAddress": "[email protected]"}, return_value
                 )
-                mock_service.users().labels().list.return_value = HttpRequestMock(
+                mock_service.users().labels().list.return_value = googleapiclient.http.HttpRequestMock(
                     None,
                     {
                         "labels": [
@@ -70,10 +70,10 @@ def test_init(mock_exists, mock_creds_from_file, mock_build, caplog):
     # Mocking necessary objects and methods
     mock_exists.return_value = True
     mock_service = MagicMock()
-    mock_service.users().getProfile.return_value = HttpRequestMock(
+    mock_service.users().getProfile.return_value = googleapiclient.http.HttpRequestMock(
         None, {"emailAddress": "[email protected]"}, return_value
     )
-    mock_service.users().labels().list.return_value = HttpRequestMock(
+    mock_service.users().labels().list.return_value = googleapiclient.http.HttpRequestMock(
         None,
         {
             "labels": [
@@ -113,10 +113,10 @@ def test_init(mock_exists, mock_creds_from_file, mock_build, caplog):
 def test_init_without_creds(mock_flow, mock_build, caplog):
     # Mocking necessary objects and methods
     mock_service = MagicMock()
-    mock_service.users().getProfile.return_value = HttpRequestMock(
+    mock_service.users().getProfile.return_value = googleapiclient.http.HttpRequestMock(
         None, {"emailAddress": "[email protected]"}, return_value
     )
-    mock_service.users().labels().list.return_value = HttpRequestMock(
+    mock_service.users().labels().list.return_value = googleapiclient.http.HttpRequestMock(
         None,
         {
             "labels": [
@@ -154,10 +154,10 @@ def test_init_without_creds(mock_flow, mock_build, caplog):
 
 
 def test_gc_get_emails(mocked_gc, simple_email_raw, caplog):
-    mocked_gc.service.users().messages().list.return_value = HttpRequestMock(
+    mocked_gc.service.users().messages().list.return_value = googleapiclient.http.HttpRequestMock(
         None, {"messages": [{"id": "123"}]}, return_value
     )
-    mocked_gc.service.users().messages().get.return_value = HttpRequestMock(
+    mocked_gc.service.users().messages().get.return_value = googleapiclient.http.HttpRequestMock(
         None,
         {
             "id": "123",
@@ -188,10 +188,10 @@ def test_gc_get_emails(mocked_gc, simple_email_raw, caplog):
 
 
 def test_gc_get_emails_complex_mail(mocked_gc, complex_email_raw, caplog):
-    mocked_gc.service.users().messages().list.return_value = HttpRequestMock(
+    mocked_gc.service.users().messages().list.return_value = googleapiclient.http.HttpRequestMock(
         None, {"messages": [{"id": "123"}]}, return_value
     )
-    mocked_gc.service.users().messages().get.return_value = HttpRequestMock(
+    mocked_gc.service.users().messages().get.return_value = googleapiclient.http.HttpRequestMock(
         None,
         {
             "id": "123",
@@ -222,7 +222,9 @@ def test_gc_get_emails_complex_mail(mocked_gc, complex_email_raw, caplog):
 
 
 def test_gc_get_emails_none(mocked_gc, simple_email_raw, caplog):
-    mocked_gc.service.users().messages().list.return_value = HttpRequestMock(None, {}, return_value)
+    mocked_gc.service.users().messages().list.return_value = googleapiclient.http.HttpRequestMock(
+        None, {}, return_value
+    )
     with caplog.at_level(logging.DEBUG):
         df = mocked_gc.get_emails(1, None, "2024/01/01", "2024/05/03")
 
@@ -236,7 +238,7 @@ def test_gc_get_emails_none(mocked_gc, simple_email_raw, caplog):
 
 @patch("builtins.input", side_effect=["y", "n"])
 def test_gc_check_or_create_label(mock_input, mocked_gc, caplog):
-    mocked_gc.service.users().labels().create.return_value = HttpRequestMock(
+    mocked_gc.service.users().labels().create.return_value = googleapiclient.http.HttpRequestMock(
         None,
         {
             "id": "Label_3",
@@ -262,7 +264,9 @@ def test_gc_check_or_create_label(mock_input, mocked_gc, caplog):
 
 
 def test_gc_move_to_done(mocked_gc, caplog):
-    mocked_gc.service.users().messages().modify.return_value = HttpRequestMock(None, {}, return_value)
+    mocked_gc.service.users().messages().modify.return_value = googleapiclient.http.HttpRequestMock(
+        None, {}, return_value
+    )
     with caplog.at_level(logging.DEBUG):
         mocked_gc.move_to_done(["dummy_id"])
 
@@ -282,7 +286,9 @@ def test_gc_move_to_error(mocked_gc, caplog):
 
 
 def test_gc_route_emails(mocked_gc, caplog):
-    mocked_gc.service.users().messages().modify.return_value = HttpRequestMock(None, {}, return_value)
+    mocked_gc.service.users().messages().modify.return_value = googleapiclient.http.HttpRequestMock(
+        None, {}, return_value
+    )
 
     df = pd.DataFrame(
         {
@@ -304,14 +310,18 @@ def test_gc_route_emails(mocked_gc, caplog):
 
 
 def test_gc_send_email(mocked_gc, fake_image, caplog):
-    mocked_gc.service.users().messages().send.return_value = HttpRequestMock(None, {"id": "12456"}, return_value)
+    mocked_gc.service.users().messages().send.return_value = googleapiclient.http.HttpRequestMock(
+        None, {"id": "12456"}, return_value
+    )
 
     with caplog.at_level(logging.DEBUG):
         mocked_gc.send_email(
-            "melusine_testing.yopmail.com",
+            "melusine_testing@yopmail.com",
             "Testing Header",
             "Testing Body",
             {"attachment.jpg": fake_image},
         )
 
-    assert "Email sent to [email protected], Message Id: 12456" in caplog.text
+    assert "12456" in caplog.text
+    assert "Email sent to" in caplog.text
+    assert "[email protected]" in caplog.text