Pull Request workflow

[theduyngx]

@Lyonville/damolab @Lyonville/iwanth1 @Lyonville/team7 @Lyonville/weexcel @Lyonville/hillclimbers
Hi all, I'd like to have a quick discussion on PR workflow. I think this should be quite easy and it would definitely make it easier to organize and track the progress. Although any discussion is more than welcome! If this is not very needed and only adds useless overhead, please also let me know.

Creating PR

I reckon most of everyone has already known this, but I think it's worth to reiterate anyway.

So, the idea of PR now is when you want to merge to another more public / widely worked on branch, you should create a PR and request for reviewers before actually doing the merge.

For example, if you want to merge your code to your team's current codebase branch (it may or may not have to be main), then you will create a PR and request for other members to review your code.

PR Workflow

After creating the PR, here is what I was thinking we should do:

• As discussed, Request Reviewer(s)
• Assign Assignees that have contributed to the PR, and those who may need to in the future
• Add an appropriate Label(s)
• Link to Project with Status, Priority, and Size
• Link to a Milestone (optional).

All of these steps simply follow each segment of the right sidebar (the Priority and Size of Project is in the +2 more view):

Branch deletion

See this discussion.