(AbstractDevice)(x) should respect Adapt.adapt_structure

[vpuri3]

The current implementation of cpu_device()(x) does not work if x, say, has an abstract FFT plan. Rather, it should call adapt_storage on x if that is defined.

https://github.com/LuxDL/Lux.jl/blob/main/lib/MLDataDevices/src/public.jl#L366

[avik-pal]

The issue with Adapt.adapt_structure is that it is opt-in and has very few structures defined.

[vpuri3]

would you recommend overloading device(x) for types that may also overload Adapt.adapt_strucure?

[vpuri3]

the issue with the functor implementation is that adapt_structure is applied to leaf elements of x. so if i want a custom conversion for x.a, that won't be possible if x.a has subfields.

the adapt approach is preferable for overloading as the conversion of x.a.b would be handled by the recursive adapt call to x.a.

[avik-pal]

Mark x.a as a MLDataDevices.isleaf or a Functors.isleaf?

[vpuri3]

Thanks, let me try that.

[vpuri3]

Thanks Avik, that did work.