-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't declare implicitly exported functions public #1147
Conversation
These functions were deprecated in a |
This error was added in JuliaLang/julia#53664. If these exports were intentional I can also remove the public declaration in Lux.jl/src/helpers/recursive_ops.jl Line 114 in bcbcbce
|
lets remove the public here |
`@deprecate` by default exports the passed functions, which I assume was not intended here. This actually causes precompilation errors on 1.12 since these functions are also declared public
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 86.00% 76.69% -9.32%
==========================================
Files 147 145 -2
Lines 6082 6054 -28
==========================================
- Hits 5231 4643 -588
- Misses 851 1411 +560 ☔ View full report in Codecov by Sentry. |
@deprecate
by default exports the passed functions,which I assume was not intended here. This actually causes precompilation errors on 1.12 since these functions are also declared public, so remove the declaration as public