Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't declare implicitly exported functions public #1147

Merged
merged 3 commits into from
Dec 28, 2024

Conversation

simeonschaub
Copy link
Contributor

@simeonschaub simeonschaub commented Dec 25, 2024

@deprecate by default exports the passed functions, which I assume was not intended here. This actually causes precompilation errors on 1.12 since these functions are also declared public, so remove the declaration as public

@avik-pal
Copy link
Member

These functions were deprecated in a 1.* release, so we would have to keep the exports around I think. Why does it error in 1.12?

@simeonschaub
Copy link
Contributor Author

This error was added in JuliaLang/julia#53664. If these exports were intentional I can also remove the public declaration in

@compat(public,
since exported bindings are automatically public.

@avik-pal
Copy link
Member

This error was added in JuliaLang/julia#53664. If these exports were intentional I can also remove the public declaration in

@compat(public,

since exported bindings are automatically public.

lets remove the public here

@simeonschaub simeonschaub changed the title don't export deprecated functions don't declare implicitly exported functions public Dec 27, 2024
simeonschaub and others added 3 commits December 28, 2024 11:19
`@deprecate` by default exports the passed functions, which I assume was not intended here. This actually causes precompilation errors on 1.12 since these functions are also declared public
@avik-pal avik-pal merged commit ac2879b into LuxDL:main Dec 28, 2024
31 of 48 checks passed
@simeonschaub simeonschaub deleted the patch-1 branch December 28, 2024 17:12
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.69%. Comparing base (90997a0) to head (540a74c).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (90997a0) and HEAD (540a74c). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (90997a0) HEAD (540a74c)
49 19
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
- Coverage   86.00%   76.69%   -9.32%     
==========================================
  Files         147      145       -2     
  Lines        6082     6054      -28     
==========================================
- Hits         5231     4643     -588     
- Misses        851     1411     +560     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants