Skip to content

Commit f36dbbc

Browse files
committed
Modify Python
1. Remove "or self.struct_names" in "vulkan_consumer_header_generator" This generator is to generate code for functions, so it's not for structures. 2. Set protect_file is True to generator "#ifndef" and "#define", instead of "#pragma once" 3. Modifiy ".h" to "\.h" in "base_generator" to fix "DISPAT_H" to "DISPATCH".
1 parent 60a1a25 commit f36dbbc

12 files changed

+20
-648
lines changed

framework/generated/generated_vulkan_consumer.h

-211
Large diffs are not rendered by default.

framework/generated/generated_vulkan_cpp_consumer_extension.h

+4-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
**
2828
*/
2929

30-
#pragma once
30+
#ifndef GFXRECON_GENERATED_VULKAN_CPP_CONSUMER_EXTENSION_H
31+
#define GFXRECON_GENERATED_VULKAN_CPP_CONSUMER_EXTENSION_H
3132

3233
#include "util/defines.h"
3334
#include "vulkan/vulkan.h"
@@ -50,3 +51,5 @@ std::string GenerateExtension(std::ostream& out, const void* struct_info, void*
5051

5152
GFXRECON_END_NAMESPACE(decode)
5253
GFXRECON_END_NAMESPACE(gfxrecon)
54+
55+
#endif

framework/generated/generated_vulkan_cpp_structs.h

+4-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
**
2828
*/
2929

30-
#pragma once
30+
#ifndef GFXRECON_GENERATED_VULKAN_CPP_STRUCTS_H
31+
#define GFXRECON_GENERATED_VULKAN_CPP_STRUCTS_H
3132

3233
#include "util/defines.h"
3334
#include "vulkan/vulkan.h"
@@ -1989,3 +1990,5 @@ std::string GenerateStruct_VkPhysicalDeviceMeshShaderPropertiesEXT(std::ostream
19891990
GFXRECON_END_NAMESPACE(decode)
19901991
GFXRECON_END_NAMESPACE(gfxrecon)
19911992

1993+
1994+
#endif

framework/generated/generated_vulkan_dispatch_table.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
**
2828
*/
2929

30-
#ifndef GFXRECON_GENERATED_VULKAN_DISPAT_H_TABLE_H
31-
#define GFXRECON_GENERATED_VULKAN_DISPAT_H_TABLE_H
30+
#ifndef GFXRECON_GENERATED_VULKAN_DISPATCH_TABLE_H
31+
#define GFXRECON_GENERATED_VULKAN_DISPATCH_TABLE_H
3232

3333
#include "format/platform_types.h"
3434
#include "util/defines.h"

framework/generated/generated_vulkan_json_consumer.h

-211
Large diffs are not rendered by default.

framework/generated/generated_vulkan_referenced_resource_consumer.h

+5
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@
2727
**
2828
*/
2929

30+
#ifndef GFXRECON_GENERATED_VULKAN_REFERENCED_RESOURCE_CONSUMER_H
31+
#define GFXRECON_GENERATED_VULKAN_REFERENCED_RESOURCE_CONSUMER_H
32+
3033
#include "decode/vulkan_referenced_resource_consumer_base.h"
3134
#include "util/defines.h"
3235

@@ -698,3 +701,5 @@ class VulkanReferencedResourceConsumer : public VulkanReferencedResourceConsumer
698701

699702
GFXRECON_END_NAMESPACE(decode)
700703
GFXRECON_END_NAMESPACE(gfxrecon)
704+
705+
#endif

framework/generated/generated_vulkan_replay_consumer.h

-211
Large diffs are not rendered by default.

framework/generated/vulkan_generators/base_generator.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ def beginFile(self, gen_opts):
439439

440440
# Multiple inclusion protection & C++ wrappers.
441441
if (gen_opts.protect_file and self.genOpts.filename):
442-
header_sym = 'GFXRECON_' + re.sub('.h', '_H', os.path.basename(self.genOpts.filename)
442+
header_sym = 'GFXRECON_' + re.sub('\.h', '_H', os.path.basename(self.genOpts.filename)
443443
).upper()
444444
write('#ifndef ', header_sym, file=self.outFile)
445445
write('#define ', header_sym, file=self.outFile)

framework/generated/vulkan_generators/gencode.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ def make_gen_opts(args):
354354
blacklists=blacklists,
355355
platform_types=platform_types,
356356
prefix_text=prefix_strings + vk_prefix_strings,
357-
protect_file=False,
357+
protect_file=True,
358358
protect_feature=False,
359359
extraVulkanHeaders=extraVulkanHeaders
360360
)
@@ -415,7 +415,7 @@ def make_gen_opts(args):
415415
blacklists = blacklists,
416416
platform_types = platform_types,
417417
prefix_text = prefix_strings + vk_prefix_strings,
418-
protect_file = False,
418+
protect_file = True,
419419
protect_feature = False)
420420
]
421421

@@ -439,7 +439,7 @@ def make_gen_opts(args):
439439
blacklists = blacklists,
440440
platform_types = platform_types,
441441
prefix_text = prefix_strings + vk_prefix_strings,
442-
protect_file = False,
442+
protect_file = True,
443443
protect_feature = False)
444444
]
445445

framework/generated/vulkan_generators/vulkan_consumer_header_generator.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def endFile(self):
145145
#
146146
# Indicates that the current feature has C++ code to generate.
147147
def need_feature_generation(self):
148-
if self.feature_cmd_params or self.struct_names:
148+
if self.feature_cmd_params:
149149
return True
150150
return False
151151

framework/generated/vulkan_generators/vulkan_cpp_consumer_extension_generator.py

-4
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,6 @@ def beginFile(self, genOpts):
108108

109109
self.is_header = genOpts.filename.endswith(".h")
110110

111-
if self.is_header:
112-
self.writeout('#pragma once')
113-
self.newline()
114-
115111
if not self.is_header:
116112
self.writeout('#include "generated/generated_vulkan_cpp_consumer_extension.h"')
117113
self.writeout('#include "generated/generated_vulkan_cpp_consumer.h"')

framework/generated/vulkan_generators/vulkan_cpp_struct_generator.py

-2
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,6 @@ def beginFile(self, genOpts):
178178
self.is_header = genOpts.filename.endswith(".h")
179179

180180
if self.is_header:
181-
self.writeout('#pragma once')
182-
self.newline()
183181
self.writeout('#include "util/defines.h"')
184182
self.includeVulkanHeaders(genOpts)
185183
self.newline()

0 commit comments

Comments
 (0)