Skip to content

Commit d3513c6

Browse files
committedJan 14, 2025
Fix rebase dev conflicts
1 parent 1a921b0 commit d3513c6

3 files changed

+7
-8
lines changed
 

‎framework/decode/vulkan_replay_dump_resources_delegate.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@ VkResult DefaultVulkanDumpResourcesDelegate::DumpRenderTargetImage(const VulkanD
136136
options_.dump_resources_dump_all_image_subresources,
137137
options_.dump_resources_dump_raw_images,
138138
options_.dump_resources_dump_separate_alpha,
139-
VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
140-
&resource_info.image_extent);
139+
VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL);
141140

142141
if (res != VK_SUCCESS)
143142
{
@@ -455,8 +454,10 @@ void DefaultVulkanDumpResourcesDelegate::GenerateOutputJsonDrawCallInfo(const Vu
455454
auto& current_block = dump_json_.GetCurrentSubEntry();
456455
auto& drawcall_json_entries =
457456
!options_.dump_resources_json_per_command ? current_block["drawCallCommands"] : current_block;
458-
auto& draw_call_entry =
459-
!options_.dump_resources_json_per_command ? drawcall_json_entries[index] : drawcall_json_entries;
457+
458+
static uint64_t unique_json_entry = 0;
459+
auto& draw_call_entry =
460+
!options_.dump_resources_json_per_command ? drawcall_json_entries[unique_json_entry++] : drawcall_json_entries;
460461

461462
draw_call_entry["drawIndex"] = draw_call_info.cmd_index;
462463
draw_call_entry["beginCommandBufferIndex"] = draw_call_info.bcb_index;

‎framework/decode/vulkan_replay_dump_resources_delegate.h

-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ struct VulkanDumpResourceInfo
7272
uint64_t sp; // subpass
7373

7474
const VulkanImageInfo* image_info;
75-
VkExtent3D image_extent;
7675
const VulkanBufferInfo* buffer_info;
7776
std::vector<uint8_t> data;
7877

‎framework/decode/vulkan_replay_dump_resources_draw_calls.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -1071,7 +1071,6 @@ VkResult DrawCallsDumpingContext::DumpRenderTargetAttachments(
10711071
res_info_base.before_cmd = dump_resources_before && !(cmd_buf_index % 2);
10721072
res_info_base.rp = rp;
10731073
res_info_base.sp = sp;
1074-
res_info_base.image_extent = { render_area[rp].extent.width, render_area[rp].extent.height, 1 };
10751074

10761075
// Dump color attachments
10771076
for (size_t i = 0; i < render_targets[rp][sp].color_att_imgs.size(); ++i)
@@ -1624,8 +1623,8 @@ VkResult DrawCallsDumpingContext::DumpVertexIndexBuffers(uint64_t qs_index, uint
16241623
// Parse all indices in order to find the smallest and greatest index
16251624
for (const auto& pairs : index_count_first_index_pairs)
16261625
{
1627-
const std::pair<uint32_t, uint32_t> min_max_indices =
1628-
FindMinMaxVertexIndices(index_data, pairs.first, pairs.second, greatest_vertex_offset, index_type);
1626+
const std::pair<uint32_t, uint32_t> min_max_indices = FindMinMaxVertexIndices(
1627+
res_info.data, pairs.first, pairs.second, greatest_vertex_offset, index_type);
16291628
if (min_max_indices.first < min_max_vertex_indices.first)
16301629
{
16311630
min_max_vertex_indices.first = min_max_indices.first;

0 commit comments

Comments
 (0)