Skip to content

Commit 0f88e9d

Browse files
committed
feat(Profile): move QR-Code button next to follow
1 parent 46772bd commit 0f88e9d

File tree

2 files changed

+24
-31
lines changed

2 files changed

+24
-31
lines changed

mastodon/src/main/java/org/joinmastodon/android/fragments/ProfileQrCodeFragment.java

+2-16
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import android.app.Activity;
1010
import android.app.Dialog;
1111
import android.app.DownloadManager;
12-
import android.app.ProgressDialog;
1312
import android.content.ContentResolver;
1413
import android.content.ContentValues;
1514
import android.content.Context;
@@ -33,13 +32,11 @@
3332
import android.os.Build;
3433
import android.os.Bundle;
3534
import android.os.Environment;
36-
import android.os.RemoteException;
3735
import android.os.SystemClock;
3836
import android.provider.MediaStore;
3937
import android.provider.Settings;
4038
import android.text.TextUtils;
4139
import android.util.AttributeSet;
42-
import android.util.Log;
4340
import android.view.ContextThemeWrapper;
4441
import android.view.KeyEvent;
4542
import android.view.LayoutInflater;
@@ -55,18 +52,7 @@
5552
import android.widget.ImageView;
5653
import android.widget.LinearLayout;
5754
import android.widget.TextView;
58-
import android.widget.Toast;
59-
60-
import com.google.android.gms.common.Feature;
61-
import com.google.android.gms.common.api.Status;
62-
import com.google.android.gms.common.moduleinstall.ModuleAvailabilityResponse;
63-
import com.google.android.gms.common.moduleinstall.ModuleInstallIntentResponse;
64-
import com.google.android.gms.common.moduleinstall.ModuleInstallResponse;
65-
import com.google.android.gms.common.moduleinstall.ModuleInstallStatusUpdate;
66-
import com.google.android.gms.common.moduleinstall.internal.ApiFeatureRequest;
67-
import com.google.android.gms.common.moduleinstall.internal.IModuleInstallCallbacks;
68-
import com.google.android.gms.common.moduleinstall.internal.IModuleInstallService;
69-
import com.google.android.gms.common.moduleinstall.internal.IModuleInstallStatusListener;
55+
7056
import com.google.zxing.BarcodeFormat;
7157
import com.google.zxing.EncodeHintType;
7258
import com.google.zxing.WriterException;
@@ -218,7 +204,7 @@ public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container,
218204
username.setText(account.username);
219205
String accDomain=account.getDomain();
220206
domain.setText(accountDomain=TextUtils.isEmpty(accDomain) ? AccountSessionManager.get(accountID).domain : accDomain);
221-
//TODO: replace the app logo with the instance avatar
207+
//TODO: replace the app logo with the instance avatar (https://github.com/mastodon/mastodon/pull/30205)
222208
Drawable logo=getResources().getDrawable(R.drawable.ic_ntf_logo, themeWrapper.getTheme()).mutate();
223209
logo.setTint(UiUtils.getThemeColor(themeWrapper, R.attr.colorM3OnPrimary));
224210
codeView.setBackground(new FancyQrCodeDrawable(code, UiUtils.getThemeColor(themeWrapper, R.attr.colorM3OnPrimary), logo));

mastodon/src/main/res/layout/fragment_profile.xml

+22-15
Original file line numberDiff line numberDiff line change
@@ -92,20 +92,6 @@
9292
android:layout_marginEnd="4dp"
9393
android:layout_weight="1">
9494

95-
<ImageButton
96-
android:id="@+id/qr_code"
97-
android:layout_width="40dp"
98-
android:layout_height="40dp"
99-
android:layout_gravity="center_vertical"
100-
style="@style/Widget.Mastodon.M3.Button.Outlined"
101-
android:tint="?colorM3OnSurfaceVariant"
102-
android:layout_marginStart="8dp"
103-
android:layout_marginEnd="1.67dp"
104-
android:contentDescription="@string/qr_code"
105-
android:scaleType="centerCrop"
106-
android:padding="9dp"
107-
android:src="@drawable/ic_fluent_qr_code_24_filled"/>
108-
10995
<org.joinmastodon.android.ui.views.ProgressBarButton
11096
android:id="@+id/notify_btn"
11197
android:layout_width="48dp"
@@ -134,7 +120,7 @@
134120
android:minHeight="48dp"
135121
android:layout_marginTop="16dp"
136122
android:layout_marginStart="4dp"
137-
android:layout_marginEnd="16dp">
123+
android:layout_marginEnd="4dp">
138124

139125
<org.joinmastodon.android.ui.views.ProgressBarButton
140126
android:id="@+id/profile_action_btn"
@@ -156,6 +142,27 @@
156142
android:outlineProvider="none"
157143
android:visibility="gone" />
158144
</FrameLayout>
145+
146+
<FrameLayout
147+
android:layout_width="wrap_content"
148+
android:layout_height="wrap_content"
149+
android:minHeight="48dp"
150+
android:layout_marginTop="16dp"
151+
android:layout_marginEnd="16dp">
152+
153+
<ImageButton
154+
android:id="@+id/qr_code"
155+
android:layout_width="40dp"
156+
android:layout_height="40dp"
157+
android:layout_gravity="center_vertical"
158+
style="@style/Widget.Mastodon.M3.Button.Outlined"
159+
android:tint="?colorM3OnSurfaceVariant"
160+
android:layout_marginStart="8dp"
161+
android:padding="8dp"
162+
android:contentDescription="@string/qr_code"
163+
android:scaleType="centerCrop"
164+
android:src="@drawable/ic_fluent_qr_code_24_filled"/>
165+
</FrameLayout>
159166
</LinearLayout>
160167

161168
</RelativeLayout>

0 commit comments

Comments
 (0)