Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM dependencies to latest (OSOE-952) #160

Open
4 tasks
Piedone opened this issue Dec 29, 2024 · 1 comment
Open
4 tasks

Update NPM dependencies to latest (OSOE-952) #160

Piedone opened this issue Dec 29, 2024 · 1 comment

Comments

@Piedone
Copy link
Member

Piedone commented Dec 29, 2024

The module's NPM dependencies are outdated, and Renovate updated them. But, due to breaking changes, manual fixes are necessary.

After updating packages to minor versions, Windows builds will suffer random failures, as explained under #162. It might be that the ESLint versions needs to be kept in sync with Node.js Extensions', see Lombiq/NodeJs-Extensions#116.

After updating packages to major versions, you'll see errors like:

71>E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js:1
71>const del = require('del');
71>
71>            ^
71>
71>EXECWITHMUTEX : error [ERR_REQUIRE_ESM]: require() of ES Module E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\node_modules\.pnpm\[email protected]\node_modules\del\index.js from E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js not supported.
71>Instead change the require of index.js in E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js to a dynamic import() which is available in all CommonJS modules.
71>    at Object.<anonymous> (E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js:1:13) {
71>  code: 'ERR_REQUIRE_ESM'
71>}
71>
71>Node.js v20.11.0
71>EXECWITHMUTEX : error : "build:vue-sfc" exited with 1.
71>
71>
71>no-path(1,1): error 1: Command failed: pnpm build
71>E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js:1
71>const del = require('del');
71>
71>            ^
71>
71>EXECWITHMUTEX : error [ERR_REQUIRE_ESM]: require() of ES Module E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\node_modules\.pnpm\[email protected]\node_modules\del\index.js from E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js not supported.
71>Instead change the require of index.js in E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js to a dynamic import() which is available in all CommonJS modules.
71>    at Object.<anonymous> (E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js:1:13) {
71>  code: 'ERR_REQUIRE_ESM'
71>}
71>
71>Node.js v20.11.0
71>EXECWITHMUTEX : error : "build:vue-sfc" exited with 1.
71>
71>EXECWITHMUTEX : error : Command failed: pnpm build
71>E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js:1
71>const del = require('del');
71>
71>            ^
71>
71>EXECWITHMUTEX : error [ERR_REQUIRE_ESM]: require() of ES Module E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\node_modules\.pnpm\[email protected]\node_modules\del\index.js from E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js not supported.
71>Instead change the require of index.js in E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js to a dynamic import() which is available in all CommonJS modules.
71>    at Object.<anonymous> (E:\ShortPath\OSOCE4\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Assets\Scripts\helpers\vue-sfc-compiler-pipeline.js:1:13) {
71>  code: 'ERR_REQUIRE_ESM'
71>}
71>
71>Node.js v20.11.0
71>EXECWITHMUTEX : error : "build:vue-sfc" exited with 1.
71>
71>    at ChildProcess.exithandler (node:child_process:422:12)
71>    at ChildProcess.emit (node:events:518:28)
71>    at maybeClose (node:internal/child_process:1105:16)
71>    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

After merging the issue branch, the Renovate PRs should close themselves.

Jira issue

@Piedone
Copy link
Member Author

Piedone commented Dec 29, 2024

Maybe you're interested @sarahelsaig?

@github-actions github-actions bot changed the title Update NPM dependencies to latest Update NPM dependencies to latest (OSOE-952) Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant