Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality and cleanliness changes according to Lombiq's PowerShell conventions (INFRA-128) #8

Open
BenedekFarkas opened this issue Nov 18, 2022 · 0 comments

Comments

@BenedekFarkas
Copy link
Member

BenedekFarkas commented Nov 18, 2022

Starting from @DAud-IcI's feedback under #5, several code styling patterns in older scripts/modules need to be brought up to par with our conventions, e.g.:

  1. HelpMessages should concise and descriptive.
  2. Unnecessary parenthesis around the input of throw and Write-Warning/Error commands.
  3. Multi-line strings should use the "Binary -join operator" format, see: OSOE-501: Enable further analyzer rules for better code styling control and more in Lombiq.Analyzers.PowerShell GitHub-Actions#179 (comment)
  4. Parameter splatting instead of backtick and line breaks. Fixed in OSOE-482: Enforce parameter splatting instead of backtick in Lombiq.Analyzers.PowerShell #10.

Jira issue

@github-actions github-actions bot changed the title Code quality and cleanliness changes according to Lombiq's PowerShell conventions Code quality and cleanliness changes according to Lombiq's PowerShell conventions (INFRA-128) Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant