COLI-1216: Combinator: File is being used by another process #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss the same file simultaneously.
Piedone
requested changes
Dec 13, 2023
Piedone
requested changes
Dec 21, 2023
| if (resourceType == ResourceType.Style) result = _combinatorService.CombineStylesheets(resources, settings); | ||
| else if (resourceType == ResourceType.JavaScript) result = _combinatorService.CombineScripts(resources, settings); | ||
| else return base.BuildRequiredResources(stringResourceType); | ||
| using (var mutex = new Mutex(initiallyOwned: false, "Global\\CombinatorFileAccess")) |
There was a problem hiding this comment.
Functionally, this is the same as a simple lock. However, a Mutex is a heavy way of synchronization across processed, what you don't need. This can either be a simple semaphore as I mentioned (with any number of readers and a single writer) or you can do a slightly more sophisticated way with a named locking approach, so the locks are different per resource bundle.
Please decide with a team whether essentially making bundle writing serially executed (across the whole app) is acceptable, or you need a named lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COLI-1216
Fixes #22.