fix(ci): add workflow_dispatch trigger and correct arm64 runner label#4
Merged
Merged
Conversation
Signed-off-by: Adam Miller <admiller@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Adam Miller <admiller@redhat.com>
Replace all NVIDIA-specific CI/build references with LobsterTrap equivalents: - Container registry: ghcr.io/nvidia/openshell -> ghcr.io/lobstertrap/openshell - CI image: ghcr.io/nvidia/openshell/ci -> ghcr.io/lobstertrap/openshell/ci - Runners: build-amd64 -> ubuntu-latest, build-arm64 -> ubuntu-24.04-arm - Dockerfile bases: nvcr.io/nvidia/base/ubuntu -> ubuntu:24.04 - Setup Buildx: remote BuildKit driver -> local docker-container driver - Removed NVIDIA GitLab CI trigger jobs from release workflows - Updated CODEOWNERS to LobsterTrap org members - Updated GitHub repo references in docs, templates, and configs Preserves upstream community sandbox image references (ghcr.io/nvidia/openshell-community) and upstream issue URLs. Signed-off-by: Adam Miller <admiller@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchtrigger for on-demand manual runsubuntu-latest-arm64(invalid) toubuntu-24.04-arm(correct per GitHub docs)Changes
File:
.github/workflows/midstream-container-build.ymlgh workflow runubuntu-latest-arm64does not exist as a GitHub-hosted runner label; the correct label isubuntu-24.04-arm. This was causing arm64 jobs to queue indefinitely with no matching runner.Usage
After merging, trigger a manual run with: