Skip to content

fix: set HOME=/root in CI image and add missing build utilities#13

Merged
maxamillion merged 1 commit into
LobsterTrap:midstreamfrom
maxamillion:container-builds
Apr 3, 2026
Merged

fix: set HOME=/root in CI image and add missing build utilities#13
maxamillion merged 1 commit into
LobsterTrap:midstreamfrom
maxamillion:container-builds

Conversation

@maxamillion

Copy link
Copy Markdown

Summary

Fixes two more container image build failures discovered after the tar/gzip and CA cert fixes.

Problem 1: mise: command not found in CI image

Hummingbird sets HOME=/tmp for root. The curl https://mise.run | sh installer places mise at $HOME/.local/bin/mise, which becomes /tmp/.local/bin/mise. The Dockerfile's PATH includes /root/.local/bin but not /tmp/.local/bin.

Fix: Add ENV HOME=/root before mise installation.

Problem 2: cmp: command not found and awk: command not found in Rust builds

The protobuf-src crate builds protobuf from source using autotools. The configure script requires cmp (from diffutils), awk (from gawk), and find (from findutils). Ubuntu includes these by default; Hummingbird does not.

Fix: Add diffutils gawk findutils to the rust-builder-base dnf install.

Dockerfile.ci: Hummingbird sets HOME=/tmp for root, causing mise to
install to /tmp/.local/bin/ which is not in PATH. Set HOME=/root
explicitly to match the PATH entries.

Dockerfile.images rust-builder-base: the protobuf-src crate builds
protobuf from source using autotools, which requires cmp (diffutils),
awk (gawk), and find (findutils). These are included in Ubuntu by
default but not in Hummingbird's minimal builder image.

Signed-off-by: Adam Miller <admiller@redhat.com>
@coderabbitai

coderabbitai Bot commented Apr 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d1d4eff4-e5d5-4bc2-8856-c2ecf0dc8cb4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@maxamillion maxamillion merged commit 0fd1c74 into LobsterTrap:midstream Apr 3, 2026
11 checks passed
maxamillion added a commit that referenced this pull request Apr 3, 2026
The protobuf-src crate compiles protobuf from source using autotools.
The configure script requires cmp (diffutils), awk (gawk), and find
(findutils). These were added to the Dockerfile.images rust-builder
stage in PR #13 but were missing from the CI image which also compiles
Rust code during lint/clippy checks.

Signed-off-by: Adam Miller <admiller@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant