fix: set HOME=/root in CI image and add missing build utilities#13
Merged
Merged
Conversation
Dockerfile.ci: Hummingbird sets HOME=/tmp for root, causing mise to install to /tmp/.local/bin/ which is not in PATH. Set HOME=/root explicitly to match the PATH entries. Dockerfile.images rust-builder-base: the protobuf-src crate builds protobuf from source using autotools, which requires cmp (diffutils), awk (gawk), and find (findutils). These are included in Ubuntu by default but not in Hummingbird's minimal builder image. Signed-off-by: Adam Miller <admiller@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
maxamillion
added a commit
that referenced
this pull request
Apr 3, 2026
The protobuf-src crate compiles protobuf from source using autotools. The configure script requires cmp (diffutils), awk (gawk), and find (findutils). These were added to the Dockerfile.images rust-builder stage in PR #13 but were missing from the CI image which also compiles Rust code during lint/clippy checks. Signed-off-by: Adam Miller <admiller@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two more container image build failures discovered after the tar/gzip and CA cert fixes.
Problem 1:
mise: command not foundin CI imageHummingbird sets
HOME=/tmpfor root. Thecurl https://mise.run | shinstaller places mise at$HOME/.local/bin/mise, which becomes/tmp/.local/bin/mise. The Dockerfile's PATH includes/root/.local/binbut not/tmp/.local/bin.Fix: Add
ENV HOME=/rootbefore mise installation.Problem 2:
cmp: command not foundandawk: command not foundin Rust buildsThe
protobuf-srccrate builds protobuf from source using autotools. The configure script requirescmp(fromdiffutils),awk(fromgawk), andfind(fromfindutils). Ubuntu includes these by default; Hummingbird does not.Fix: Add
diffutils gawk findutilsto the rust-builder-basednf install.