fix: add tar/gzip to CI image and fix CA cert path for nvidia-ctk stage#12
Merged
Merged
Conversation
Dockerfile.ci: add gzip to dnf install (tar was already listed but gzip is needed for tar xz decompression of Docker CLI archive). Dockerfile.images nvidia-ctk stage: create symlink from the standard Fedora CA bundle path (/etc/pki/tls/certs/ca-bundle.crt) to the Hummingbird-provided bundle (/etc/pki/ca-trust/extracted/pem/ tls-ca-bundle.pem). The NVIDIA repo config hardcodes the former path which does not exist on Hummingbird images. Signed-off-by: Adam Miller <admiller@redhat.com>
maxamillion
requested review from
cgwalters,
fatherlinux,
openchow and
sallyom
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two remaining container image build failures.
Problem 1:
gzip: Cannot exec: No such file or directoryin CI imageThe Docker CLI install step uses
tar xzwhich requiresgzip. The Hummingbirdcore-runtime:latest-builderdoesn't includegzip.Problem 2: SSL CA cert path mismatch in nvidia-container-toolkit stage
The NVIDIA repo config hardcodes
sslcacert=/etc/pki/tls/certs/ca-bundle.crt. Hummingbird images store the CA bundle at/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.peminstead. Even afterupdate-ca-trust, the expected path doesn't exist.Fix
gzipto the CI image'sdnf installlist/etc/pki/tls/certs/ca-bundle.crt->/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pemBoth fixes verified locally with
podman run.